From a602ecf8fb3a0cfd54ea18dad561df5eec7ec5c7 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Mon, 14 Oct 2019 15:22:30 +0200 Subject: [PATCH] make buildx: clean-up comment and fix help-text Un-indent the comment, so that it doesn't get printed by the shell script (moved it above the target, as it looked slightly less cluttered) Also fixed the "help" comment, so that it shows up in `make help`, and removed the un-needed dummy `buildx:` target. Signed-off-by: Sebastiaan van Stijn --- Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 2e89aa8240..ab02c1669d 100644 --- a/Makefile +++ b/Makefile @@ -247,14 +247,13 @@ swagger-docs: ## preview the API documentation .PHONY: buildx ifeq ($(BUILDX), bundles/buildx) -buildx: bundles/buildx # build buildx cli tool -else -buildx: +buildx: bundles/buildx ## build buildx cli tool endif +# This intentionally is not using the `--output` flag from the docker CLI, which +# is a buildkit option. The idea here being that if buildx is being used, it's +# because buildkit is not supported natively bundles/buildx: bundles ## build buildx CLI tool - # This intetionally is not using the `--output` flag from the docker CLI which is a buildkit option - # The idea here being that if buildx is being used, it's because buildkit is not supported natively docker build -f $${BUILDX_DOCKERFILE:-Dockerfile.buildx} -t "moby-buildx:$${BUILDX_COMMIT:-latest}" \ --build-arg BUILDX_COMMIT \ --build-arg BUILDX_REPO \