From a617809fe7cd59b8825cfad80af772d7b3595024 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sat, 12 Oct 2019 20:43:17 +0200 Subject: [PATCH] testutil: use constants for http methods Signed-off-by: Sebastiaan van Stijn --- testutil/daemon/daemon.go | 4 ++-- testutil/request/request.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testutil/daemon/daemon.go b/testutil/daemon/daemon.go index d6a7a07276..cd172cae15 100644 --- a/testutil/daemon/daemon.go +++ b/testutil/daemon/daemon.go @@ -328,7 +328,7 @@ func (d *Daemon) StartWithLogFile(out *os.File, providedArgs ...string) error { Transport: clientConfig.transport, } - req, err := http.NewRequest("GET", "/_ping", nil) + req, err := http.NewRequest(http.MethodGet, "/_ping", nil) if err != nil { return errors.Wrapf(err, "[%s] could not create new request", d.id) } @@ -683,7 +683,7 @@ func (d *Daemon) queryRootDir() (string, error) { Transport: clientConfig.transport, } - req, err := http.NewRequest("GET", "/info", nil) + req, err := http.NewRequest(http.MethodGet, "/info", nil) if err != nil { return "", err } diff --git a/testutil/request/request.go b/testutil/request/request.go index f41219a06f..bc9fc1ee19 100644 --- a/testutil/request/request.go +++ b/testutil/request/request.go @@ -115,7 +115,7 @@ func newRequest(endpoint string, opts *Options) (*http.Request, error) { if err != nil { return nil, errors.Wrapf(err, "failed parsing url %q", opts.host) } - req, err := http.NewRequest("GET", endpoint, nil) + req, err := http.NewRequest(http.MethodGet, endpoint, nil) if err != nil { return nil, errors.Wrap(err, "failed to create request") }