From 6184ff312dce3222d71ec7c2769002e2dd7595ed Mon Sep 17 00:00:00 2001 From: allencloud Date: Wed, 28 Sep 2016 14:41:19 +0800 Subject: [PATCH] change code in container restore Signed-off-by: allencloud --- daemon/daemon.go | 19 ++-------- integration-cli/docker_cli_daemon_test.go | 43 ----------------------- 2 files changed, 3 insertions(+), 59 deletions(-) diff --git a/daemon/daemon.go b/daemon/daemon.go index 9911f3d2a3..65c88dc772 100644 --- a/daemon/daemon.go +++ b/daemon/daemon.go @@ -51,7 +51,6 @@ import ( "github.com/docker/docker/reference" "github.com/docker/docker/registry" "github.com/docker/docker/runconfig" - "github.com/docker/docker/utils" volumedrivers "github.com/docker/docker/volume/drivers" "github.com/docker/docker/volume/local" "github.com/docker/docker/volume/store" @@ -106,27 +105,20 @@ type Daemon struct { func (daemon *Daemon) restore() error { var ( - debug = utils.IsDebugEnabled() currentDriver = daemon.GraphDriverName() containers = make(map[string]*container.Container) ) - if !debug { - logrus.Info("Loading containers: start.") - } + logrus.Info("Loading containers: start.") + dir, err := ioutil.ReadDir(daemon.repository) if err != nil { return err } - containerCount := 0 for _, v := range dir { id := v.Name() container, err := daemon.load(id) - if !debug && logrus.GetLevel() == logrus.InfoLevel { - fmt.Print(".") - containerCount++ - } if err != nil { logrus.Errorf("Failed to load container %v: %v", id, err) continue @@ -348,12 +340,7 @@ func (daemon *Daemon) restore() error { group.Wait() - if !debug { - if logrus.GetLevel() == logrus.InfoLevel && containerCount > 0 { - fmt.Println() - } - logrus.Info("Loading containers: done.") - } + logrus.Info("Loading containers: done.") return nil } diff --git a/integration-cli/docker_cli_daemon_test.go b/integration-cli/docker_cli_daemon_test.go index eca3489926..98ab0f915a 100644 --- a/integration-cli/docker_cli_daemon_test.go +++ b/integration-cli/docker_cli_daemon_test.go @@ -1247,49 +1247,6 @@ func (s *DockerDaemonSuite) TestDaemonLoggingDriverNoneLogsError(c *check.C) { c.Assert(out, checker.Contains, expected) } -func (s *DockerDaemonSuite) TestDaemonDots(c *check.C) { - if err := s.d.StartWithBusybox(); err != nil { - c.Fatal(err) - } - - // Now create 4 containers - if _, err := s.d.Cmd("create", "busybox"); err != nil { - c.Fatalf("Error creating container: %q", err) - } - if _, err := s.d.Cmd("create", "busybox"); err != nil { - c.Fatalf("Error creating container: %q", err) - } - if _, err := s.d.Cmd("create", "busybox"); err != nil { - c.Fatalf("Error creating container: %q", err) - } - if _, err := s.d.Cmd("create", "busybox"); err != nil { - c.Fatalf("Error creating container: %q", err) - } - - s.d.Stop() - - s.d.Start("--log-level=debug") - s.d.Stop() - content, _ := ioutil.ReadFile(s.d.logFile.Name()) - if strings.Contains(string(content), "....") { - c.Fatalf("Debug level should not have ....\n%s", string(content)) - } - - s.d.Start("--log-level=error") - s.d.Stop() - content, _ = ioutil.ReadFile(s.d.logFile.Name()) - if strings.Contains(string(content), "....") { - c.Fatalf("Error level should not have ....\n%s", string(content)) - } - - s.d.Start("--log-level=info") - s.d.Stop() - content, _ = ioutil.ReadFile(s.d.logFile.Name()) - if !strings.Contains(string(content), "....") { - c.Fatalf("Info level should have ....\n%s", string(content)) - } -} - func (s *DockerDaemonSuite) TestDaemonUnixSockCleanedUp(c *check.C) { dir, err := ioutil.TempDir("", "socket-cleanup-test") if err != nil {