diff --git a/integration-cli/docker_api_swarm_test.go b/integration-cli/docker_api_swarm_test.go index 97e7e6ba51..10b9938486 100644 --- a/integration-cli/docker_api_swarm_test.go +++ b/integration-cli/docker_api_swarm_test.go @@ -404,7 +404,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveRemovesContainer(c *check.C) { d.CreateService(c, simpleTestService, setInstances(instances)) id, err := d.Cmd("run", "-d", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", id)) id = strings.TrimSpace(id) waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, instances+1) @@ -415,7 +415,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveRemovesContainer(c *check.C) { waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) id2, err := d.Cmd("ps", "-q") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", id2)) c.Assert(id, checker.HasPrefix, strings.TrimSpace(id2)) } @@ -426,7 +426,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveOnPendingJoin(c *check.C) { d2 := s.AddDaemon(c, false, false) id, err := d2.Cmd("run", "-d", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", id)) id = strings.TrimSpace(id) c2 := d2.NewClientT(c) @@ -445,7 +445,7 @@ func (s *DockerSwarmSuite) TestAPISwarmLeaveOnPendingJoin(c *check.C) { waitAndAssert(c, defaultReconciliationTimeout, d2.CheckActiveContainerCount, checker.Equals, 1) id2, err := d2.Cmd("ps", "-q") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", id2)) c.Assert(id, checker.HasPrefix, strings.TrimSpace(id2)) } diff --git a/integration-cli/docker_cli_config_create_test.go b/integration-cli/docker_cli_config_create_test.go index a04081df23..c777a76374 100644 --- a/integration-cli/docker_cli_config_create_test.go +++ b/integration-cli/docker_cli_config_create_test.go @@ -15,17 +15,17 @@ func (s *DockerSwarmSuite) TestConfigCreateWithFile(c *check.C) { d := s.AddDaemon(c, true, true) testFile, err := ioutil.TempFile("", "configCreateTest") - c.Assert(err, checker.IsNil, check.Commentf("failed to create temporary file")) + c.Assert(err, checker.IsNil) // ensure temp file is created defer os.Remove(testFile.Name()) testData := "TESTINGDATA" _, err = testFile.Write([]byte(testData)) - c.Assert(err, checker.IsNil, check.Commentf("failed to write to temporary file")) + c.Assert(err, checker.IsNil) // ensure temp file is written testName := "test_config" out, err := d.Cmd("config", "create", testName, testFile.Name()) - c.Assert(err, checker.IsNil) - c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "", check.Commentf("%s", out)) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) + c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") id := strings.TrimSpace(out) config := d.GetConfig(c, id) diff --git a/integration-cli/docker_cli_daemon_plugins_test.go b/integration-cli/docker_cli_daemon_plugins_test.go index b04a5be932..9a11c68089 100644 --- a/integration-cli/docker_cli_daemon_plugins_test.go +++ b/integration-cli/docker_cli_daemon_plugins_test.go @@ -287,16 +287,16 @@ func (s *DockerDaemonSuite) TestPluginListFilterEnabled(c *check.C) { }() out, err = s.d.Cmd("plugin", "ls", "--filter", "enabled=true") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Not(checker.Contains), pName) out, err = s.d.Cmd("plugin", "ls", "--filter", "enabled=false") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, pName) c.Assert(out, checker.Contains, "false") out, err = s.d.Cmd("plugin", "ls") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, pName) } @@ -315,14 +315,14 @@ func (s *DockerDaemonSuite) TestPluginListFilterCapability(c *check.C) { }() out, err = s.d.Cmd("plugin", "ls", "--filter", "capability=volumedriver") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, pName) out, err = s.d.Cmd("plugin", "ls", "--filter", "capability=authz") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Not(checker.Contains), pName) out, err = s.d.Cmd("plugin", "ls") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, pName) } diff --git a/integration-cli/docker_cli_daemon_test.go b/integration-cli/docker_cli_daemon_test.go index b99a3fc980..edb2a7b6c9 100644 --- a/integration-cli/docker_cli_daemon_test.go +++ b/integration-cli/docker_cli_daemon_test.go @@ -107,7 +107,7 @@ func (s *DockerDaemonSuite) TestDaemonRestartWithVolumesRefs(c *check.C) { } out, err := s.d.Cmd("inspect", "-f", "{{json .Mounts}}", "volrestarttest1") - c.Assert(err, check.IsNil) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) if _, err := inspectMountPointJSON(out, "/foo"); err != nil { c.Fatalf("Expected volume to exist: /foo, error: %v\n", err) @@ -387,22 +387,20 @@ func (s *DockerDaemonSuite) TestDaemonIPv6Enabled(c *check.C) { } out, err := s.d.Cmd("inspect", "--format", "'{{.NetworkSettings.Networks.bridge.LinkLocalIPv6Address}}'", "ipv6test") - out = strings.Trim(out, " \r\n'") - if err != nil { c.Fatalf("Error inspecting container: %s, %v", out, err) } + out = strings.Trim(out, " \r\n'") if ip := net.ParseIP(out); ip == nil { c.Fatalf("Container should have a link-local IPv6 address") } out, err = s.d.Cmd("inspect", "--format", "'{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}'", "ipv6test") - out = strings.Trim(out, " \r\n'") - if err != nil { c.Fatalf("Error inspecting container: %s, %v", out, err) } + out = strings.Trim(out, " \r\n'") if ip := net.ParseIP(out); ip != nil { c.Fatalf("Container should not have a global IPv6 address: %v", out) @@ -424,9 +422,8 @@ func (s *DockerDaemonSuite) TestDaemonIPv6FixedCIDR(c *check.C) { c.Assert(err, checker.IsNil, check.Commentf("Could not run container: %s, %v", out, err)) out, err = s.d.Cmd("inspect", "--format", "{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}", "ipv6test") - out = strings.Trim(out, " \r\n'") - c.Assert(err, checker.IsNil, check.Commentf("%s", out)) + out = strings.Trim(out, " \r\n'") ip := net.ParseIP(out) c.Assert(ip, checker.NotNil, check.Commentf("Container should have a global IPv6 address")) @@ -448,11 +445,11 @@ func (s *DockerDaemonSuite) TestDaemonIPv6FixedCIDRAndMac(c *check.C) { s.d.StartWithBusybox(c, "--ipv6", "--fixed-cidr-v6=2001:db8:1::/64") - _, err := s.d.Cmd("run", "-itd", "--name=ipv6test", "--mac-address", "AA:BB:CC:DD:EE:FF", "busybox") - c.Assert(err, checker.IsNil) + out, err := s.d.Cmd("run", "-itd", "--name=ipv6test", "--mac-address", "AA:BB:CC:DD:EE:FF", "busybox") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) - out, err := s.d.Cmd("inspect", "--format", "{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}", "ipv6test") - c.Assert(err, checker.IsNil) + out, err = s.d.Cmd("inspect", "--format", "{{.NetworkSettings.Networks.bridge.GlobalIPv6Address}}", "ipv6test") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.Trim(out, " \r\n'"), checker.Equals, "2001:db8:1::aabb:ccdd:eeff") } @@ -467,7 +464,7 @@ func (s *DockerDaemonSuite) TestDaemonIPv6HostMode(c *check.C) { c.Assert(err, checker.IsNil, check.Commentf("Could not run container: %s, %v", out, err)) out, err = s.d.Cmd("exec", "hostcnt", "ip", "-6", "addr", "show", "docker0") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.Trim(out, " \r\n'"), checker.Contains, "2001:db8:2::1") } @@ -600,8 +597,8 @@ func (s *DockerDaemonSuite) TestDaemonBridgeExternal(c *check.C) { Out: ipTablesSearchString, }) - _, err = d.Cmd("run", "-d", "--name", "ExtContainer", "busybox", "top") - c.Assert(err, check.IsNil) + out, err := d.Cmd("run", "-d", "--name", "ExtContainer", "busybox", "top") + c.Assert(err, check.IsNil, check.Commentf("%s", out)) containerIP := d.FindContainerIP(c, "ExtContainer") ip := net.ParseIP(containerIP) @@ -671,8 +668,8 @@ func (s *DockerDaemonSuite) TestDaemonBridgeIP(c *check.C) { Out: ipTablesSearchString, }) - _, err := d.Cmd("run", "-d", "--name", "test", "busybox", "top") - c.Assert(err, check.IsNil) + out, err := d.Cmd("run", "-d", "--name", "test", "busybox", "top") + c.Assert(err, check.IsNil, check.Commentf("%s", out)) containerIP := d.FindContainerIP(c, "test") ip = net.ParseIP(containerIP) @@ -782,7 +779,7 @@ func (s *DockerDaemonSuite) TestDaemonDefaultGatewayIPv4Implicit(c *check.C) { expectedMessage := fmt.Sprintf("default via %s dev", bridgeIP) out, err := d.Cmd("run", "busybox", "ip", "-4", "route", "list", "0/0") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.Contains(out, expectedMessage), check.Equals, true, check.Commentf("Implicit default gateway should be bridge IP %s, but default route was '%s'", bridgeIP, strings.TrimSpace(out))) @@ -804,7 +801,7 @@ func (s *DockerDaemonSuite) TestDaemonDefaultGatewayIPv4Explicit(c *check.C) { expectedMessage := fmt.Sprintf("default via %s dev", gatewayIP) out, err := d.Cmd("run", "busybox", "ip", "-4", "route", "list", "0/0") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.Contains(out, expectedMessage), check.Equals, true, check.Commentf("Explicit default gateway should be %s, but default route was '%s'", gatewayIP, strings.TrimSpace(out))) @@ -858,7 +855,7 @@ func (s *DockerDaemonSuite) TestDaemonIP(c *check.C) { defer deleteInterface(c, ifName) _, err = d.Cmd("run", "-d", "-p", "8000:8000", "busybox", "top") - c.Assert(err, check.IsNil) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) result := icmd.RunCommand("iptables", "-t", "nat", "-nvL") result.Assert(c, icmd.Success) @@ -900,8 +897,8 @@ func (s *DockerDaemonSuite) TestDaemonICCPing(c *check.C) { // But, Pinging external or a Host interface must succeed pingCmd := fmt.Sprintf("ping -c 1 %s -W 1", ip.String()) runArgs := []string{"run", "--rm", "busybox", "sh", "-c", pingCmd} - _, err := d.Cmd(runArgs...) - c.Assert(err, check.IsNil) + out, err := d.Cmd(runArgs...) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) } func (s *DockerDaemonSuite) TestDaemonICCLinkExpose(c *check.C) { @@ -940,10 +937,10 @@ func (s *DockerDaemonSuite) TestDaemonLinksIpTablesRulesWhenLinkAndUnlink(c *che s.d.StartWithBusybox(c, "--bridge", bridgeName, "--icc=false") defer s.d.Restart(c) - _, err := s.d.Cmd("run", "-d", "--name", "child", "--publish", "8080:80", "busybox", "top") - c.Assert(err, check.IsNil) - _, err = s.d.Cmd("run", "-d", "--name", "parent", "--link", "child:http", "busybox", "top") - c.Assert(err, check.IsNil) + out, err := s.d.Cmd("run", "-d", "--name", "child", "--publish", "8080:80", "busybox", "top") + c.Assert(err, check.IsNil, check.Commentf("%s", out)) + out, err = s.d.Cmd("run", "-d", "--name", "parent", "--link", "child:http", "busybox", "top") + c.Assert(err, check.IsNil, check.Commentf("%s", out)) childIP := s.d.FindContainerIP(c, "child") parentIP := s.d.FindContainerIP(c, "parent") @@ -970,7 +967,7 @@ func (s *DockerDaemonSuite) TestDaemonUlimitDefaults(c *check.C) { out, err := s.d.Cmd("run", "--ulimit", "nproc=2048", "--name=test", "busybox", "/bin/sh", "-c", "echo $(ulimit -n); echo $(ulimit -p)") if err != nil { - c.Fatal(out, err) + c.Fatal(err, out) } outArr := strings.Split(out, "\n") @@ -992,7 +989,7 @@ func (s *DockerDaemonSuite) TestDaemonUlimitDefaults(c *check.C) { out, err = s.d.Cmd("start", "-a", "test") if err != nil { - c.Fatal(err) + c.Fatal(err, out) } outArr = strings.Split(out, "\n") @@ -1566,22 +1563,22 @@ func (s *DockerDaemonSuite) TestDaemonRestartWithContainerWithRestartPolicyAlway s.d.StartWithBusybox(c) out, err := s.d.Cmd("run", "-d", "--restart", "always", "busybox", "top") - c.Assert(err, check.IsNil) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) id := strings.TrimSpace(out) - _, err = s.d.Cmd("stop", id) - c.Assert(err, check.IsNil) - _, err = s.d.Cmd("wait", id) - c.Assert(err, check.IsNil) + out, err = s.d.Cmd("stop", id) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) + out, err = s.d.Cmd("wait", id) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) out, err = s.d.Cmd("ps", "-q") - c.Assert(err, check.IsNil) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) c.Assert(out, check.Equals, "") s.d.Restart(c) out, err = s.d.Cmd("ps", "-q") - c.Assert(err, check.IsNil) + c.Assert(err, check.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), check.Equals, id[:12]) } @@ -1650,12 +1647,12 @@ func (s *DockerDaemonSuite) TestDaemonRestartRmVolumeInUse(c *check.C) { func (s *DockerDaemonSuite) TestDaemonRestartLocalVolumes(c *check.C) { s.d.Start(c) - _, err := s.d.Cmd("volume", "create", "test") - c.Assert(err, check.IsNil) + out, err := s.d.Cmd("volume", "create", "test") + c.Assert(err, check.IsNil, check.Commentf("%s", out)) s.d.Restart(c) - _, err = s.d.Cmd("volume", "inspect", "test") - c.Assert(err, check.IsNil) + out, err = s.d.Cmd("volume", "inspect", "test") + c.Assert(err, check.IsNil, check.Commentf("%s", out)) } // FIXME(vdemeester) should be a unit test @@ -1762,7 +1759,7 @@ func (s *DockerDaemonSuite) TestBridgeIPIsExcludedFromAllocatorPool(c *check.C) break } ip, err := s.d.Cmd("inspect", "--format", "'{{.NetworkSettings.IPAddress}}'", contName) - c.Assert(err, check.IsNil) + c.Assert(err, check.IsNil, check.Commentf("%s", ip)) c.Assert(ip, check.Not(check.Equals), bridgeIP) cont++ @@ -1792,7 +1789,7 @@ func (s *DockerDaemonSuite) TestDaemonNoSpaceLeftOnDeviceError(c *check.C) { // pull a repository large enough to overfill the mounted filesystem pullOut, err := s.d.Cmd("pull", "debian:stretch") - c.Assert(err, checker.NotNil, check.Commentf(pullOut)) + c.Assert(err, checker.NotNil, check.Commentf("%s", pullOut)) c.Assert(pullOut, checker.Contains, "no space left on device") } diff --git a/integration-cli/docker_cli_swarm_test.go b/integration-cli/docker_cli_swarm_test.go index 9c108e0ecc..f6fadcf995 100644 --- a/integration-cli/docker_cli_swarm_test.go +++ b/integration-cli/docker_cli_swarm_test.go @@ -41,7 +41,7 @@ func (s *DockerSwarmSuite) TestSwarmUpdate(c *check.C) { } out, err := d.Cmd("swarm", "update", "--cert-expiry", "30h", "--dispatcher-heartbeat", "11s") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", out)) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) spec := getSpec() c.Assert(spec.CAConfig.NodeCertExpiry, checker.Equals, 30*time.Hour) @@ -169,7 +169,7 @@ func (s *DockerSwarmSuite) TestSwarmIncompatibleDaemon(c *check.C) { func (s *DockerSwarmSuite) TestSwarmServiceTemplatingHostname(c *check.C) { d := s.AddDaemon(c, true, true) hostname, err := d.Cmd("node", "inspect", "--format", "{{.Description.Hostname}}", "self") - c.Assert(err, checker.IsNil, check.Commentf(hostname)) + c.Assert(err, checker.IsNil, check.Commentf("%s", hostname)) out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", "test", "--hostname", "{{.Service.Name}}-{{.Task.Slot}}-{{.Node.Hostname}}", "busybox", "top") c.Assert(err, checker.IsNil, check.Commentf("%s", out)) @@ -191,15 +191,15 @@ func (s *DockerSwarmSuite) TestSwarmServiceListFilter(c *check.C) { name2 := "redis-cluster" name3 := "other-cluster" out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name1, "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name2, "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name3, "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") filter1 := "name=redis-cluster-md5" @@ -207,19 +207,19 @@ func (s *DockerSwarmSuite) TestSwarmServiceListFilter(c *check.C) { // We search checker.Contains with `name+" "` to prevent prefix only. out, err = d.Cmd("service", "ls", "--filter", filter1) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name1+" ") c.Assert(out, checker.Not(checker.Contains), name2+" ") c.Assert(out, checker.Not(checker.Contains), name3+" ") out, err = d.Cmd("service", "ls", "--filter", filter2) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name1+" ") c.Assert(out, checker.Contains, name2+" ") c.Assert(out, checker.Not(checker.Contains), name3+" ") out, err = d.Cmd("service", "ls") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name1+" ") c.Assert(out, checker.Contains, name2+" ") c.Assert(out, checker.Contains, name3+" ") @@ -229,18 +229,18 @@ func (s *DockerSwarmSuite) TestSwarmNodeListFilter(c *check.C) { d := s.AddDaemon(c, true, true) out, err := d.Cmd("node", "inspect", "--format", "{{ .Description.Hostname }}", "self") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") name := strings.TrimSpace(out) filter := "name=" + name[:4] out, err = d.Cmd("node", "ls", "--filter", filter) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name) out, err = d.Cmd("node", "ls", "--filter", "name=none") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Not(checker.Contains), name) } @@ -249,7 +249,7 @@ func (s *DockerSwarmSuite) TestSwarmNodeTaskListFilter(c *check.C) { name := "redis-cluster-md5" out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--replicas=3", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") // make sure task has been deployed. @@ -258,13 +258,13 @@ func (s *DockerSwarmSuite) TestSwarmNodeTaskListFilter(c *check.C) { filter := "name=redis-cluster" out, err = d.Cmd("node", "ps", "--filter", filter, "self") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name+".1") c.Assert(out, checker.Contains, name+".2") c.Assert(out, checker.Contains, name+".3") out, err = d.Cmd("node", "ps", "--filter", "name=none", "self") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Not(checker.Contains), name+".1") c.Assert(out, checker.Not(checker.Contains), name+".2") c.Assert(out, checker.Not(checker.Contains), name+".3") @@ -276,20 +276,20 @@ func (s *DockerSwarmSuite) TestSwarmPublishAdd(c *check.C) { name := "top" out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--label", "x=y", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") - _, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name) - c.Assert(err, checker.IsNil) + out, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) - _, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name) - c.Assert(err, checker.IsNil) + out, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", name) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) _, err = d.Cmd("service", "update", "--detach", "--publish-add", "80:80", "--publish-add", "80:20", name) c.Assert(err, checker.NotNil) out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.EndpointSpec.Ports }}", name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Equals, "[{ tcp 80 80 ingress}]") } @@ -298,20 +298,20 @@ func (s *DockerSwarmSuite) TestSwarmServiceWithGroup(c *check.C) { name := "top" out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--user", "root:root", "--group", "wheel", "--group", "audio", "--group", "staff", "--group", "777", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") // make sure task has been deployed. waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) out, err = d.Cmd("ps", "-q") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") container := strings.TrimSpace(out) out, err = d.Cmd("exec", container, "id") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Equals, "uid=0(root) gid=0(root) groups=10(wheel),29(audio),50(staff),777") } @@ -319,7 +319,7 @@ func (s *DockerSwarmSuite) TestSwarmContainerAutoStart(c *check.C) { d := s.AddDaemon(c, true, true) out, err := d.Cmd("network", "create", "--attachable", "-d", "overlay", "foo") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") out, err = d.Cmd("run", "-id", "--restart=always", "--net=foo", "--name=test", "busybox", "top") @@ -366,20 +366,20 @@ func (s *DockerSwarmSuite) TestSwarmContainerAttachByNetworkId(c *check.C) { d := s.AddDaemon(c, true, true) out, err := d.Cmd("network", "create", "--attachable", "-d", "overlay", "testnet") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") networkID := strings.TrimSpace(out) out, err = d.Cmd("run", "-d", "--net", networkID, "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) cID := strings.TrimSpace(out) d.WaitRun(cID) - _, err = d.Cmd("rm", "-f", cID) - c.Assert(err, checker.IsNil) + out, err = d.Cmd("rm", "-f", cID) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) - _, err = d.Cmd("network", "rm", "testnet") - c.Assert(err, checker.IsNil) + out, err = d.Cmd("network", "rm", "testnet") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) checkNetwork := func(*check.C) (interface{}, check.CommentInterface) { out, err := d.Cmd("network", "ls") @@ -430,12 +430,12 @@ func (s *DockerSwarmSuite) TestOverlayAttachableOnSwarmLeave(c *check.C) { // Check the container is disconnected out, err = d.Cmd("inspect", "c1", "--format", "{{.NetworkSettings.Networks."+nwName+"}}") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Equals, "") // Check the network is gone out, err = d.Cmd("network", "ls", "--format", "{{.Name}}") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Not(checker.Contains), nwName) } @@ -451,8 +451,8 @@ func (s *DockerSwarmSuite) TestOverlayAttachableReleaseResourcesOnFailure(c *che c.Assert(err, checker.IsNil, check.Commentf("%s", out)) // Attempt to attach another container with same IP, must fail - _, err = d.Cmd("run", "-d", "--network", "ovnet", "--name", "c2", "--ip", "10.10.9.33", "busybox", "top") - c.Assert(err, checker.NotNil) + out, err = d.Cmd("run", "-d", "--network", "ovnet", "--name", "c2", "--ip", "10.10.9.33", "busybox", "top") + c.Assert(err, checker.NotNil, check.Commentf("%s", out)) // Remove first container out, err = d.Cmd("rm", "-f", "c1") @@ -541,14 +541,14 @@ func (s *DockerSwarmSuite) TestSwarmTaskListFilter(c *check.C) { name := "redis-cluster-md5" out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--replicas=3", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") filter := "name=redis-cluster" checkNumTasks := func(*check.C) (interface{}, check.CommentInterface) { out, err := d.Cmd("service", "ps", "--filter", filter, name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) return len(strings.Split(out, "\n")) - 2, nil // includes header and nl in last line } @@ -556,41 +556,41 @@ func (s *DockerSwarmSuite) TestSwarmTaskListFilter(c *check.C) { waitAndAssert(c, defaultReconciliationTimeout, checkNumTasks, checker.Equals, 3) out, err = d.Cmd("service", "ps", "--filter", filter, name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name+".1") c.Assert(out, checker.Contains, name+".2") c.Assert(out, checker.Contains, name+".3") out, err = d.Cmd("service", "ps", "--filter", "name="+name+".1", name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name+".1") c.Assert(out, checker.Not(checker.Contains), name+".2") c.Assert(out, checker.Not(checker.Contains), name+".3") out, err = d.Cmd("service", "ps", "--filter", "name=none", name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Not(checker.Contains), name+".1") c.Assert(out, checker.Not(checker.Contains), name+".2") c.Assert(out, checker.Not(checker.Contains), name+".3") name = "redis-cluster-sha1" out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--mode=global", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") waitAndAssert(c, defaultReconciliationTimeout, checkNumTasks, checker.Equals, 1) filter = "name=redis-cluster" out, err = d.Cmd("service", "ps", "--filter", filter, name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name) out, err = d.Cmd("service", "ps", "--filter", "name="+name, name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, name) out, err = d.Cmd("service", "ps", "--filter", "name=none", name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Not(checker.Contains), name) } @@ -599,12 +599,12 @@ func (s *DockerSwarmSuite) TestPsListContainersFilterIsTask(c *check.C) { // Create a bare container out, err := d.Cmd("run", "-d", "--name=bare-container", "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) bareID := strings.TrimSpace(out)[:12] // Create a service name := "busybox-top" out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") // make sure task has been deployed. @@ -612,13 +612,13 @@ func (s *DockerSwarmSuite) TestPsListContainersFilterIsTask(c *check.C) { // Filter non-tasks out, err = d.Cmd("ps", "-a", "-q", "--filter=is-task=false") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) psOut := strings.TrimSpace(out) c.Assert(psOut, checker.Equals, bareID, check.Commentf("Expected id %s, got %s for is-task label, output %q", bareID, psOut, out)) // Filter tasks out, err = d.Cmd("ps", "-a", "-q", "--filter=is-task=true") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) lines := strings.Split(strings.Trim(out, "\n "), "\n") c.Assert(lines, checker.HasLen, 1) c.Assert(lines[0], checker.Not(checker.Equals), bareID, check.Commentf("Expected not %s, but got it for is-task label, output %q", bareID, out)) @@ -798,7 +798,7 @@ func setupRemoteGlobalNetworkPlugin(c *check.C, mux *http.ServeMux, url, netDrv, func (s *DockerSwarmSuite) TestSwarmNetworkPlugin(c *check.C) { mux := http.NewServeMux() s.server = httptest.NewServer(mux) - c.Assert(s.server, check.NotNil, check.Commentf("Failed to start an HTTP Server")) + c.Assert(s.server, check.NotNil) // check that HTTP server has started setupRemoteGlobalNetworkPlugin(c, mux, s.server.URL, globalNetworkPlugin, globalIPAMPlugin) defer func() { s.server.Close() @@ -809,7 +809,7 @@ func (s *DockerSwarmSuite) TestSwarmNetworkPlugin(c *check.C) { d := s.AddDaemon(c, true, true) out, err := d.Cmd("network", "create", "-d", globalNetworkPlugin, "foo") - c.Assert(err, checker.NotNil) + c.Assert(err, checker.NotNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, "not supported in swarm mode") } @@ -823,12 +823,12 @@ func (s *DockerSwarmSuite) TestSwarmServiceEnvFile(c *check.C) { name := "worker" out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--env-file", path, "--env", "VAR1=B", "--env", "VAR1=C", "--env", "VAR2=", "--env", "VAR2", "--name", name, "busybox", "top") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "") // The complete env is [VAR1=A VAR2=A VAR1=B VAR1=C VAR2= VAR2] and duplicates will be removed => [VAR1=C VAR2] out, err = d.Cmd("inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.Env }}", name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, "[VAR1=C VAR2]") } @@ -841,42 +841,42 @@ func (s *DockerSwarmSuite) TestSwarmServiceTTY(c *check.C) { // Without --tty expectedOutput := "none" - _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "sh", "-c", ttyCheck) - c.Assert(err, checker.IsNil) - - // Make sure task has been deployed. - waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) - - // We need to get the container id. - out, err := d.Cmd("ps", "-q", "--no-trunc") - c.Assert(err, checker.IsNil) - id := strings.TrimSpace(out) - - out, err = d.Cmd("exec", id, "cat", "/status") - c.Assert(err, checker.IsNil) - c.Assert(out, checker.Contains, expectedOutput, check.Commentf("Expected '%s', but got %q", expectedOutput, out)) - - // Remove service - _, err = d.Cmd("service", "rm", name) - c.Assert(err, checker.IsNil) - // Make sure container has been destroyed. - waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 0) - - // With --tty - expectedOutput = "TTY" - _, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--tty", "busybox", "sh", "-c", ttyCheck) - c.Assert(err, checker.IsNil) + out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "sh", "-c", ttyCheck) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) // Make sure task has been deployed. waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) // We need to get the container id. out, err = d.Cmd("ps", "-q", "--no-trunc") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) + id := strings.TrimSpace(out) + + out, err = d.Cmd("exec", id, "cat", "/status") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) + c.Assert(out, checker.Contains, expectedOutput, check.Commentf("Expected '%s', but got %q", expectedOutput, out)) + + // Remove service + out, err = d.Cmd("service", "rm", name) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) + // Make sure container has been destroyed. + waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 0) + + // With --tty + expectedOutput = "TTY" + out, err = d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--tty", "busybox", "sh", "-c", ttyCheck) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) + + // Make sure task has been deployed. + waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) + + // We need to get the container id. + out, err = d.Cmd("ps", "-q", "--no-trunc") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) id = strings.TrimSpace(out) out, err = d.Cmd("exec", id, "cat", "/status") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, expectedOutput, check.Commentf("Expected '%s', but got %q", expectedOutput, out)) } @@ -885,21 +885,21 @@ func (s *DockerSwarmSuite) TestSwarmServiceTTYUpdate(c *check.C) { // Create a service name := "top" - _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top") - c.Assert(err, checker.IsNil) + out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) // Make sure task has been deployed. waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) - out, err := d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.TTY }}", name) - c.Assert(err, checker.IsNil) + out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.TTY }}", name) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Equals, "false") - _, err = d.Cmd("service", "update", "--detach", "--tty", name) - c.Assert(err, checker.IsNil) + out, err = d.Cmd("service", "update", "--detach", "--tty", name) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.TTY }}", name) - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Equals, "true") } @@ -947,15 +947,15 @@ func (s *DockerSwarmSuite) TestDNSConfig(c *check.C) { // Create a service name := "top" - _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--dns=1.2.3.4", "--dns-search=example.com", "--dns-option=timeout:3", "busybox", "top") - c.Assert(err, checker.IsNil) + out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--dns=1.2.3.4", "--dns-search=example.com", "--dns-option=timeout:3", "busybox", "top") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) // Make sure task has been deployed. waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) // We need to get the container id. - out, err := d.Cmd("ps", "-a", "-q", "--no-trunc") - c.Assert(err, checker.IsNil) + out, err = d.Cmd("ps", "-a", "-q", "--no-trunc") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) id := strings.TrimSpace(out) // Compare against expected output. @@ -963,7 +963,7 @@ func (s *DockerSwarmSuite) TestDNSConfig(c *check.C) { expectedOutput2 := "search example.com" expectedOutput3 := "options timeout:3" out, err = d.Cmd("exec", id, "cat", "/etc/resolv.conf") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, expectedOutput1, check.Commentf("Expected '%s', but got %q", expectedOutput1, out)) c.Assert(out, checker.Contains, expectedOutput2, check.Commentf("Expected '%s', but got %q", expectedOutput2, out)) c.Assert(out, checker.Contains, expectedOutput3, check.Commentf("Expected '%s', but got %q", expectedOutput3, out)) @@ -974,17 +974,17 @@ func (s *DockerSwarmSuite) TestDNSConfigUpdate(c *check.C) { // Create a service name := "top" - _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top") - c.Assert(err, checker.IsNil) + out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "busybox", "top") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) // Make sure task has been deployed. waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) - _, err = d.Cmd("service", "update", "--detach", "--dns-add=1.2.3.4", "--dns-search-add=example.com", "--dns-option-add=timeout:3", name) - c.Assert(err, checker.IsNil) + out, err = d.Cmd("service", "update", "--detach", "--dns-add=1.2.3.4", "--dns-search-add=example.com", "--dns-option-add=timeout:3", name) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) - out, err := d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.DNSConfig }}", name) - c.Assert(err, checker.IsNil) + out, err = d.Cmd("service", "inspect", "--format", "{{ .Spec.TaskTemplate.ContainerSpec.DNSConfig }}", name) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(strings.TrimSpace(out), checker.Equals, "{[1.2.3.4] [example.com] [timeout:3]}") } @@ -1037,8 +1037,8 @@ func (s *DockerSwarmSuite) TestUnlockEngineAndUnlockedSwarm(c *check.C) { c.Assert(result.Combined(), checker.Contains, "Error: This node is not part of a swarm") c.Assert(result.Combined(), checker.Not(checker.Contains), "Please enter unlock key") - _, err := d.Cmd("swarm", "init") - c.Assert(err, checker.IsNil) + out, err := d.Cmd("swarm", "init") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) // unlocking an unlocked swarm should return an error - it does not even ask for the key cmd = d.Command("swarm", "unlock") @@ -1054,7 +1054,7 @@ func (s *DockerSwarmSuite) TestSwarmInitLocked(c *check.C) { d := s.AddDaemon(c, false, false) outs, err := d.Cmd("swarm", "init", "--autolock") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Contains, "docker swarm unlock") @@ -1069,7 +1069,7 @@ func (s *DockerSwarmSuite) TestSwarmInitLocked(c *check.C) { c.Assert(unlockKey, checker.Not(checker.Equals), "") outs, err = d.Cmd("swarm", "unlock-key", "-q") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Equals, unlockKey+"\n") c.Assert(getNodeStatus(c, d), checker.Equals, swarm.LocalNodeStateActive) @@ -1094,16 +1094,16 @@ func (s *DockerSwarmSuite) TestSwarmInitLocked(c *check.C) { c.Assert(getNodeStatus(c, d), checker.Equals, swarm.LocalNodeStateActive) outs, err = d.Cmd("node", "ls") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Not(checker.Contains), "Swarm is encrypted and needs to be unlocked") outs, err = d.Cmd("swarm", "update", "--autolock=false") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) checkSwarmLockedToUnlocked(c, d, unlockKey) outs, err = d.Cmd("node", "ls") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Not(checker.Contains), "Swarm is encrypted and needs to be unlocked") } @@ -1111,7 +1111,7 @@ func (s *DockerSwarmSuite) TestSwarmLeaveLocked(c *check.C) { d := s.AddDaemon(c, false, false) outs, err := d.Cmd("swarm", "init", "--autolock") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) // It starts off locked d.Restart(c, "--swarm-default-advertise-addr=lo") @@ -1128,13 +1128,13 @@ func (s *DockerSwarmSuite) TestSwarmLeaveLocked(c *check.C) { // It is OK for user to leave a locked swarm with --force outs, err = d.Cmd("swarm", "leave", "--force") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) info = d.SwarmInfo(c) c.Assert(info.LocalNodeState, checker.Equals, swarm.LocalNodeStateInactive) outs, err = d.Cmd("swarm", "init") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) info = d.SwarmInfo(c) c.Assert(info.LocalNodeState, checker.Equals, swarm.LocalNodeStateActive) @@ -1154,7 +1154,7 @@ func (s *DockerSwarmSuite) TestSwarmLockUnlockCluster(c *check.C) { // enable autolock outs, err := d1.Cmd("swarm", "update", "--autolock") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Contains, "docker swarm unlock") @@ -1379,7 +1379,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterRotateUnlockKey(c *check.C) { d3 := s.AddDaemon(c, true, true) outs, err := d1.Cmd("swarm", "update", "--autolock") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Contains, "docker swarm unlock") @@ -1394,13 +1394,13 @@ func (s *DockerSwarmSuite) TestSwarmClusterRotateUnlockKey(c *check.C) { c.Assert(unlockKey, checker.Not(checker.Equals), "") outs, err = d1.Cmd("swarm", "unlock-key", "-q") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Equals, unlockKey+"\n") // Rotate multiple times for i := 0; i != 3; i++ { outs, err = d1.Cmd("swarm", "unlock-key", "-q", "--rotate") - c.Assert(err, checker.IsNil, check.Commentf("out: %v", outs)) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) // Strip \n newUnlockKey := outs[:len(outs)-1] c.Assert(newUnlockKey, checker.Not(checker.Equals), "") @@ -1451,7 +1451,7 @@ func (s *DockerSwarmSuite) TestSwarmClusterRotateUnlockKey(c *check.C) { c.Assert(getNodeStatus(c, d), checker.Equals, swarm.LocalNodeStateActive) outs, err = d.Cmd("node", "ls") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", outs)) c.Assert(outs, checker.Not(checker.Contains), "Swarm is encrypted and needs to be unlocked") } @@ -1497,21 +1497,21 @@ func (s *DockerSwarmSuite) TestExtraHosts(c *check.C) { // Create a service name := "top" - _, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--host=example.com:1.2.3.4", "busybox", "top") - c.Assert(err, checker.IsNil) + out, err := d.Cmd("service", "create", "--detach", "--no-resolve-image", "--name", name, "--host=example.com:1.2.3.4", "busybox", "top") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) // Make sure task has been deployed. waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1) // We need to get the container id. - out, err := d.Cmd("ps", "-a", "-q", "--no-trunc") - c.Assert(err, checker.IsNil) + out, err = d.Cmd("ps", "-a", "-q", "--no-trunc") + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) id := strings.TrimSpace(out) // Compare against expected output. expectedOutput := "1.2.3.4\texample.com" out, err = d.Cmd("exec", id, "cat", "/etc/hosts") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, expectedOutput, check.Commentf("Expected '%s', but got %q", expectedOutput, out)) } @@ -1524,15 +1524,15 @@ func (s *DockerSwarmSuite) TestSwarmManagerAddress(c *check.C) { expectedOutput := fmt.Sprintf("Manager Addresses:\n 127.0.0.1:%d\n", d1.SwarmPort) out, err := d1.Cmd("info") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, expectedOutput) out, err = d2.Cmd("info") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, expectedOutput) out, err = d3.Cmd("info") - c.Assert(err, checker.IsNil) + c.Assert(err, checker.IsNil, check.Commentf("%s", out)) c.Assert(out, checker.Contains, expectedOutput) }