mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Fix docker import tests
For me when I run the test I see: ``` Downloading from http://nourl/bad Importing 283 B Untar re-exec error: exit status 1: output: unexpected EOF ``` and nothing about "dial tcp" so it appears that the output is system dependent and therefore we can't really check it. I think checking for non-zero exit code is sufficient so I'm removing this string check. Signed-off-by: Doug Davis <dug@us.ibm.com>
This commit is contained in:
parent
f18224de14
commit
ac043c7db6
2 changed files with 6 additions and 2 deletions
|
@ -35,7 +35,11 @@ func (s *DockerSuite) TestImportBadURL(c *check.C) {
|
|||
testRequires(c, DaemonIsLinux)
|
||||
out, _, err := dockerCmdWithError("import", "http://nourl/bad")
|
||||
c.Assert(err, checker.NotNil, check.Commentf("import was supposed to fail but didn't"))
|
||||
c.Assert(out, checker.Contains, "dial tcp", check.Commentf("expected an error msg but didn't get one"))
|
||||
// Depending on your system you can get either of these errors
|
||||
if !strings.Contains(out, "dial tcp") &&
|
||||
!strings.Contains(out, "Error processing tar file") {
|
||||
c.Fatalf("expected an error msg but didn't get one.\nErr: %v\nOut: %v", err, out)
|
||||
}
|
||||
}
|
||||
|
||||
func (s *DockerSuite) TestImportFile(c *check.C) {
|
||||
|
|
|
@ -80,7 +80,7 @@ func invokeUnpack(decompressedArchive io.Reader, dest string, options *archive.T
|
|||
// pending on write pipe forever
|
||||
io.Copy(ioutil.Discard, decompressedArchive)
|
||||
|
||||
return fmt.Errorf("Untar re-exec error: %v: output: %s", err, output)
|
||||
return fmt.Errorf("Error processing tar file(%v): %s", err, output)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue