From ac599d652846f6456366b8028b2c38da0565d8b1 Mon Sep 17 00:00:00 2001 From: Michael Crosby Date: Mon, 10 Jun 2013 14:44:10 -0900 Subject: [PATCH] Add explicit status response to OPTIONS handler Write the http.StatusOK header in the OPTIONS handler and update the unit tests to refer to the response code using the const from the http package. --- api.go | 1 + api_test.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/api.go b/api.go index cc00849a60..681b719c1a 100644 --- a/api.go +++ b/api.go @@ -793,6 +793,7 @@ func createRouter(srv *Server, logging bool) (*mux.Router, error) { if srv.enableCors { writeCorsHeaders(w, r) } + w.WriteHeader(http.StatusOK) }) return r, nil } diff --git a/api_test.go b/api_test.go index 748bcf812c..62da94113a 100644 --- a/api_test.go +++ b/api_test.go @@ -1260,7 +1260,7 @@ func TestOptionsRoute(t *testing.T) { } router.ServeHTTP(r, req) - if r.Code != 200 { + if r.Code != http.StatusOK { t.Errorf("Expected response for OPTIONS request to be \"200\", %v found.", r.Code) } } @@ -1287,7 +1287,7 @@ func TestGetEnabledCors(t *testing.T) { } router.ServeHTTP(r, req) - if r.Code != 200 { + if r.Code != http.StatusOK { t.Errorf("Expected response for OPTIONS request to be \"200\", %v found.", r.Code) }