From cad770f992ee5837273a02edb28f73624898bee1 Mon Sep 17 00:00:00 2001 From: Pavel Tikhomirov Date: Tue, 17 Feb 2015 13:15:51 +0300 Subject: [PATCH] integration-cli: check that docker port command output is not empty Or else we can violate array range boundaries in: out = strings.Split(out, ":")[1] and get runtime error. We got this runtime error when run TestRunPortFromDockerRangeInUse Somehow docker goes silently if it cannot publish port because of no bridge. Signed-off-by: Pavel Tikhomirov --- integration-cli/docker_cli_run_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/integration-cli/docker_cli_run_test.go b/integration-cli/docker_cli_run_test.go index 491acad771..6e759eef1c 100644 --- a/integration-cli/docker_cli_run_test.go +++ b/integration-cli/docker_cli_run_test.go @@ -2921,6 +2921,10 @@ func TestRunPortFromDockerRangeInUse(t *testing.T) { t.Fatal(out, err) } out = strings.TrimSpace(out) + + if out == "" { + t.Fatal("docker port command output is empty") + } out = strings.Split(out, ":")[1] lastPort, err := strconv.Atoi(out) if err != nil {