kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity

graph: validate tags properly & add unit tests 

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (github: unclejack)
This commit is contained in:
unclejack 2014-09-16 00:13:54 +03:00
parent 88a786d3c4
commit ada883b198
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
graph/tags.go
View File

@ -19,7 +19,7 @@ import (
const DEFAULTTAG = "latest"
var (
validTagName = regexp.MustCompile(`^[\w][\w.-]{1,29}$`)
validTagName = regexp.MustCompile(`^[\w][\w.-]{0,29}$`)
)
type TagStore struct {

18
graph/tags_unit_test.go
View File

@ -114,3 +114,21 @@ func TestLookupImage(t *testing.T) {
t.Errorf("Expected 1 image, none found")
}
}
func TestValidTagName(t *testing.T) {
validTags := []string{"9", "foo", "foo-test", "bar.baz.boo"}
for _, tag := range validTags {
if err := validateTagName(tag); err != nil {
t.Errorf("'%s' should've been a valid tag", tag)
}
}
}
func TestInvalidTagName(t *testing.T) {
validTags := []string{"-9", ".foo", "-test", ".", "-"}
for _, tag := range validTags {
if err := validateTagName(tag); err == nil {
t.Errorf("'%s' shouldn't have been a valid tag", tag)
}
}
}