mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Merge pull request #16804 from Microsoft/jjh/fixpullimageifnotexist
No err shadowing on pullImageIfNotExist
This commit is contained in:
commit
aee0fcf413
1 changed files with 3 additions and 3 deletions
|
@ -609,16 +609,16 @@ func imageExists(image string) error {
|
|||
return err
|
||||
}
|
||||
|
||||
func pullImageIfNotExist(image string) (err error) {
|
||||
func pullImageIfNotExist(image string) error {
|
||||
if err := imageExists(image); err != nil {
|
||||
pullCmd := exec.Command(dockerBinary, "pull", image)
|
||||
_, exitCode, err := runCommandWithOutput(pullCmd)
|
||||
|
||||
if err != nil || exitCode != 0 {
|
||||
err = fmt.Errorf("image %q wasn't found locally and it couldn't be pulled: %s", image, err)
|
||||
return fmt.Errorf("image %q wasn't found locally and it couldn't be pulled: %s", image, err)
|
||||
}
|
||||
}
|
||||
return
|
||||
return nil
|
||||
}
|
||||
|
||||
func dockerCmdWithError(args ...string) (string, int, error) {
|
||||
|
|
Loading…
Add table
Reference in a new issue