kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Add more error details on plugin get

Browse source 
Seeing this `ErrNotImplements` in some of our logs and it's not very
helpful because we don't know what plugin is causing it or even what the
requested interface is.

```
{"message":"legacy plugin: Plugin does not implement the requested driver"}
```

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This commit is contained in:
Brian Goff 2020-07-15 13:10:30 -07:00
parent 60c45c332f
commit b1a3fe4934
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/plugins/plugins.go
View file

@ -24,6 +24,7 @@ package plugins // import "github.com/docker/docker/pkg/plugins"
import (
"errors"
"fmt"
"sync"
"time"
@ -265,7 +266,7 @@ func Get(name, imp string) (*Plugin, error) {
logrus.Debugf("%s implements: %s", name, imp)
return pl, nil
}
return nil, ErrNotImplements
return nil, fmt.Errorf("%w: plugin=%q, requested implementation=%q", ErrNotImplements, name, imp)
}
// Handle adds the specified function to the extpointHandlers.