From b28c1eae01e73fb92fe46f60a1bbd4e4f5a223b1 Mon Sep 17 00:00:00 2001 From: yupengzte Date: Thu, 18 May 2017 17:16:19 +0800 Subject: [PATCH] ineffectual assignment to isCanonical, delete it Signed-off-by: yupengzte --- client/service_create.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/client/service_create.go b/client/service_create.go index 90082d150f..ccdb11be2a 100644 --- a/client/service_create.go +++ b/client/service_create.go @@ -55,12 +55,9 @@ func (cli *Client) ServiceCreate(ctx context.Context, service swarm.ServiceSpec, // the image string if it didn't originally contain a digest. It assumes // that the image string is not an image ID func imageWithDigestString(image string, dgst digest.Digest) string { - isCanonical := false ref, err := reference.ParseAnyReference(image) if err == nil { - _, isCanonical = ref.(reference.Canonical) - - if !isCanonical { + if _, isCanonical := ref.(reference.Canonical); !isCanonical { namedRef, _ := ref.(reference.Named) img, err := reference.WithDigest(namedRef, dgst) if err == nil {