From b365924ec3eb073d9501d90ec7ab66cc8c2a6872 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 19 Apr 2022 17:40:33 +0200 Subject: [PATCH] client: ContainerKill(): don't send signal query-param if none was set Just a small clean-up (there's more endpoints to do this for, but I was working on changes in this area on the CLI when I noticed we were setting this query-parameter unconditionally. Signed-off-by: Sebastiaan van Stijn --- client/container_kill.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/client/container_kill.go b/client/container_kill.go index 4d6f1d23da..7c9529f1e1 100644 --- a/client/container_kill.go +++ b/client/container_kill.go @@ -8,7 +8,9 @@ import ( // ContainerKill terminates the container process but does not remove the container from the docker host. func (cli *Client) ContainerKill(ctx context.Context, containerID, signal string) error { query := url.Values{} - query.Set("signal", signal) + if signal != "" { + query.Set("signal", signal) + } resp, err := cli.post(ctx, "/containers/"+containerID+"/kill", query, nil, nil) ensureReaderClosed(resp)