From d1ad0e278d67baad46168f6d04a56550a287d4a7 Mon Sep 17 00:00:00 2001 From: unclejack Date: Fri, 23 Aug 2013 18:59:11 +0300 Subject: [PATCH] return error if at least one container fails to start This makes docker start exit with exit code 1 if at least one container didn't start. This also prints an error at the end. --- commands.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/commands.go b/commands.go index b38069f075..21531231af 100644 --- a/commands.go +++ b/commands.go @@ -584,15 +584,17 @@ func (cli *DockerCli) CmdStart(args ...string) error { return nil } + var encounteredError error for _, name := range args { _, _, err := cli.call("POST", "/containers/"+name+"/start", nil) if err != nil { fmt.Fprintf(cli.err, "%s\n", err) + encounteredError = fmt.Errorf("Error: failed to start one or more containers") } else { fmt.Fprintf(cli.out, "%s\n", name) } } - return nil + return encounteredError } func (cli *DockerCli) CmdInspect(args ...string) error {