Move pkg/gitutils to remotecontext/git

Signed-off-by: Daniel Nephin <dnephin@docker.com>

builder/remotecontext/git.go

@@ -4,13 +4,13 @@ import (
 	"os"
 
 	"github.com/docker/docker/builder"
+	"github.com/docker/docker/builder/remotecontext/git"
 	"github.com/docker/docker/pkg/archive"
-	"github.com/docker/docker/pkg/gitutils"
 )
 
 // MakeGitContext returns a Context from gitURL that is cloned in a temporary directory.
 func MakeGitContext(gitURL string) (builder.Source, error) {
-	root, err := gitutils.Clone(gitURL)
+	root, err := git.Clone(gitURL)
 	if err != nil {
 		return nil, err
 	}

builder/remotecontext/git/gitutils.go

@@ -1,4 +1,4 @@
-package gitutils
+package git
 
 import (
 	"fmt"

builder/remotecontext/git/gitutils_test.go

@@ -1,4 +1,4 @@
-package gitutils
+package git
 
 import (
 	"fmt"
@@ -8,10 +8,12 @@ import (
 	"net/url"
 	"os"
 	"path/filepath"
-	"reflect"
 	"runtime"
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestCloneArgsSmartHttp(t *testing.T) {
@@ -28,9 +30,7 @@ func TestCloneArgsSmartHttp(t *testing.T) {
 
 	args := fetchArgs(serverURL, "master")
 	exp := []string{"fetch", "--recurse-submodules=yes", "--depth", "1", "origin", "master"}
-	if !reflect.DeepEqual(args, exp) {
+	assert.Equal(t, exp, args)
-		t.Fatalf("Expected %v, got %v", exp, args)
-	}
 }
 
 func TestCloneArgsDumbHttp(t *testing.T) {
@@ -46,18 +46,14 @@ func TestCloneArgsDumbHttp(t *testing.T) {
 
 	args := fetchArgs(serverURL, "master")
 	exp := []string{"fetch", "--recurse-submodules=yes", "origin", "master"}
-	if !reflect.DeepEqual(args, exp) {
+	assert.Equal(t, exp, args)
-		t.Fatalf("Expected %v, got %v", exp, args)
-	}
 }
 
 func TestCloneArgsGit(t *testing.T) {
 	u, _ := url.Parse("git://github.com/docker/docker")
 	args := fetchArgs(u, "master")
 	exp := []string{"fetch", "--recurse-submodules=yes", "--depth", "1", "origin", "master"}
-	if !reflect.DeepEqual(args, exp) {
+	assert.Equal(t, exp, args)
-		t.Fatalf("Expected %v, got %v", exp, args)
-	}
 }
 
 func gitGetConfig(name string) string {
@@ -72,9 +68,7 @@ func gitGetConfig(name string) string {
 
 func TestCheckoutGit(t *testing.T) {
 	root, err := ioutil.TempDir("", "docker-build-git-checkout")
-	if err != nil {
+	require.NoError(t, err)
-		t.Fatal(err)
-	}
 	defer os.RemoveAll(root)
 
 	autocrlf := gitGetConfig("core.autocrlf")
@@ -89,30 +83,22 @@ func TestCheckoutGit(t *testing.T) {
 
 	gitDir := filepath.Join(root, "repo")
 	_, err = git("init", gitDir)
-	if err != nil {
+	require.NoError(t, err)
-		t.Fatal(err)
-	}
 
-	if _, err = gitWithinDir(gitDir, "config", "user.email", "test@docker.com"); err != nil {
+	_, err = gitWithinDir(gitDir, "config", "user.email", "test@docker.com")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if _, err = gitWithinDir(gitDir, "config", "user.name", "Docker test"); err != nil {
+	_, err = gitWithinDir(gitDir, "config", "user.name", "Docker test")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if err = ioutil.WriteFile(filepath.Join(gitDir, "Dockerfile"), []byte("FROM scratch"), 0644); err != nil {
+	err = ioutil.WriteFile(filepath.Join(gitDir, "Dockerfile"), []byte("FROM scratch"), 0644)
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
 	subDir := filepath.Join(gitDir, "subdir")
-	if err = os.Mkdir(subDir, 0755); err != nil {
+	require.NoError(t, os.Mkdir(subDir, 0755))
-		t.Fatal(err)
-	}
 
-	if err = ioutil.WriteFile(filepath.Join(subDir, "Dockerfile"), []byte("FROM scratch\nEXPOSE 5000"), 0644); err != nil {
+	err = ioutil.WriteFile(filepath.Join(subDir, "Dockerfile"), []byte("FROM scratch\nEXPOSE 5000"), 0644)
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
 	if runtime.GOOS != "windows" {
 		if err = os.Symlink("../subdir", filepath.Join(gitDir, "parentlink")); err != nil {
@@ -124,37 +110,29 @@ func TestCheckoutGit(t *testing.T) {
 		}
 	}
 
-	if _, err = gitWithinDir(gitDir, "add", "-A"); err != nil {
+	_, err = gitWithinDir(gitDir, "add", "-A")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if _, err = gitWithinDir(gitDir, "commit", "-am", "First commit"); err != nil {
+	_, err = gitWithinDir(gitDir, "commit", "-am", "First commit")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if _, err = gitWithinDir(gitDir, "checkout", "-b", "test"); err != nil {
+	_, err = gitWithinDir(gitDir, "checkout", "-b", "test")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if err = ioutil.WriteFile(filepath.Join(gitDir, "Dockerfile"), []byte("FROM scratch\nEXPOSE 3000"), 0644); err != nil {
+	err = ioutil.WriteFile(filepath.Join(gitDir, "Dockerfile"), []byte("FROM scratch\nEXPOSE 3000"), 0644)
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if err = ioutil.WriteFile(filepath.Join(subDir, "Dockerfile"), []byte("FROM busybox\nEXPOSE 5000"), 0644); err != nil {
+	err = ioutil.WriteFile(filepath.Join(subDir, "Dockerfile"), []byte("FROM busybox\nEXPOSE 5000"), 0644)
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if _, err = gitWithinDir(gitDir, "add", "-A"); err != nil {
+	_, err = gitWithinDir(gitDir, "add", "-A")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if _, err = gitWithinDir(gitDir, "commit", "-am", "Branch commit"); err != nil {
+	_, err = gitWithinDir(gitDir, "commit", "-am", "Branch commit")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
-	if _, err = gitWithinDir(gitDir, "checkout", "master"); err != nil {
+	_, err = gitWithinDir(gitDir, "checkout", "master")
-		t.Fatal(err)
+	require.NoError(t, err)
-	}
 
 	type singleCase struct {
 		frag string
@@ -190,21 +168,13 @@ func TestCheckoutGit(t *testing.T) {
 		ref, subdir := getRefAndSubdir(c.frag)
 		r, err := checkoutGit(gitDir, ref, subdir)
 
-		fail := err != nil
-		if fail != c.fail {
-			t.Fatalf("Expected %v failure, error was %v\n", c.fail, err)
-		}
 		if c.fail {
+			assert.Error(t, err)
 			continue
 		}
 
 		b, err := ioutil.ReadFile(filepath.Join(r, "Dockerfile"))
-		if err != nil {
+		require.NoError(t, err)
-			t.Fatal(err)
+		assert.Equal(t, c.exp, string(b))
-		}
-
-		if string(b) != c.exp {
-			t.Fatalf("Expected %v, was %v\n", c.exp, string(b))
-		}
 	}
 }