mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
Explictly set state of a disabled plugin.
While restoring plugins during daemon restart, some plugins can fail to respond to net.Dial. These plugins should be explicitly set to disabled, else they will retain their original state of enabled, which is incorrect. Tested with a plugin that fails to restart and observed that the state was set to disabled. Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
This commit is contained in:
parent
d8406fd7a0
commit
bbbf64f712
1 changed files with 2 additions and 0 deletions
|
@ -97,6 +97,8 @@ func (pm *Manager) pluginPostStart(p *v2.Plugin, c *controller) error {
|
|||
if retries > maxRetries {
|
||||
logrus.Debugf("error net dialing plugin: %v", err)
|
||||
c.restart = false
|
||||
// While restoring plugins, we need to explicitly set the state to disabled
|
||||
pm.config.Store.SetState(p, false)
|
||||
shutdownPlugin(p, c, pm.containerdClient)
|
||||
return err
|
||||
}
|
||||
|
|
Loading…
Add table
Reference in a new issue