kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #16215 from HuKeping/save

Browse source 
Refactor CLI docker save
This commit is contained in:
Brian Goff 2015-09-11 13:52:59 -04:00
commit bc48194ded
2 changed files with 13 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api/client/cli.go
View file

@ -52,7 +52,7 @@ type DockerCli struct {
outFd uintptr outFd uintptr
// isTerminalIn indicates whether the client's STDIN is a TTY // isTerminalIn indicates whether the client's STDIN is a TTY
isTerminalIn bool isTerminalIn bool
// isTerminalOut dindicates whether the client's STDOUT is a TTY // isTerminalOut indicates whether the client's STDOUT is a TTY
isTerminalOut bool isTerminalOut bool
// transport holds the client transport instance. // transport holds the client transport instance.
transport *http.Transport transport *http.Transport

29
api/client/save.go
View file

@ -25,13 +25,14 @@ func (cli *DockerCli) CmdSave(args ...string) error {
output = cli.out output = cli.out
err error err error
) )
if *outfile == "" && cli.isTerminalOut {
return errors.New("Cowardly refusing to save to a terminal. Use the -o flag or redirect.")
}
if *outfile != "" { if *outfile != "" {
output, err = os.Create(*outfile) if output, err = os.Create(*outfile); err != nil {
if err != nil {
return err return err
} }
} else if cli.isTerminalOut {
return errors.New("Cowardly refusing to save to a terminal. Use the -o flag or redirect.")
} }
sopts := &streamOpts{ sopts := &streamOpts{
@ -39,19 +40,13 @@ func (cli *DockerCli) CmdSave(args ...string) error {
out: output, out: output,
} }
if len(cmd.Args()) == 1 { v := url.Values{}
image := cmd.Arg(0) for _, arg := range cmd.Args() {
if _, err := cli.stream("GET", "/images/"+image+"/get", sopts); err != nil { v.Add("names", arg)
return err
}
} else {
v := url.Values{}
for _, arg := range cmd.Args() {
v.Add("names", arg)
}
if _, err := cli.stream("GET", "/images/get?"+v.Encode(), sopts); err != nil {
return err
}
} }
if _, err := cli.stream("GET", "/images/get?"+v.Encode(), sopts); err != nil {
return err
}
return nil return nil
} }