From be20dc15af0cb281bd6d11586cfcc96bd50d12ca Mon Sep 17 00:00:00 2001 From: Kenfe-Mickael Laventure Date: Wed, 11 Jan 2017 13:42:49 -0800 Subject: [PATCH] Fix ImageSummary.Size value The prune PR changed the meaning of the file to mean "space on disk only unique to this image", this PR revert this change. Signed-off-by: Kenfe-Mickael Laventure --- cli/command/formatter/image.go | 7 +++---- daemon/images.go | 5 +---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/cli/command/formatter/image.go b/cli/command/formatter/image.go index 594b2f3926..5c7de826f0 100644 --- a/cli/command/formatter/image.go +++ b/cli/command/formatter/image.go @@ -226,8 +226,7 @@ func (c *imageContext) CreatedAt() string { func (c *imageContext) Size() string { c.AddHeader(sizeHeader) - //NOTE: For backward compatibility we need to return VirtualSize - return units.HumanSizeWithPrecision(float64(c.i.VirtualSize), 3) + return units.HumanSizeWithPrecision(float64(c.i.Size), 3) } func (c *imageContext) Containers() string { @@ -253,8 +252,8 @@ func (c *imageContext) SharedSize() string { func (c *imageContext) UniqueSize() string { c.AddHeader(uniqueSizeHeader) - if c.i.Size == -1 { + if c.i.VirtualSize == -1 || c.i.SharedSize == -1 { return "N/A" } - return units.HumanSize(float64(c.i.Size)) + return units.HumanSize(float64(c.i.VirtualSize - c.i.SharedSize)) } diff --git a/daemon/images.go b/daemon/images.go index 25fad4ca00..01dbced164 100644 --- a/daemon/images.go +++ b/daemon/images.go @@ -210,7 +210,6 @@ func (daemon *Daemon) Images(imageFilters filters.Args, all bool, withExtraAttrs rootFS := *img.RootFS rootFS.DiffIDs = nil - newImage.Size = 0 newImage.SharedSize = 0 for _, id := range img.RootFS.DiffIDs { rootFS.Append(id) @@ -223,8 +222,6 @@ func (daemon *Daemon) Images(imageFilters filters.Args, all bool, withExtraAttrs if layerRefs[chid] > 1 { newImage.SharedSize += diffSize - } else { - newImage.Size += diffSize } } } @@ -323,7 +320,7 @@ func newImage(image *image.Image, virtualSize int64) *types.ImageSummary { newImage.ParentID = image.Parent.String() newImage.ID = image.ID().String() newImage.Created = image.Created.Unix() - newImage.Size = -1 + newImage.Size = virtualSize newImage.VirtualSize = virtualSize newImage.SharedSize = -1 newImage.Containers = -1