kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

volume/local: add test for validation

Browse source 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2022-06-02 23:59:44 +02:00
parent 0e04b514fb
commit c1671abf14
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 114 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

114
volume/local/local_linux_test.go
View file

@ -6,8 +6,10 @@ package local // import "github.com/docker/docker/volume/local"
import (
"os"
"path/filepath"
"strconv"
"testing"
"github.com/docker/docker/errdefs"
"github.com/docker/docker/pkg/idtools"
"github.com/docker/docker/quota"
"gotest.tools/v3/assert"
@ -95,3 +97,115 @@ func testVolQuotaUnsupported(t *testing.T, mountPoint, backingFsDev, testDir str
_, err = vol.Mount("1234")
assert.ErrorContains(t, err, "no quota support")
}
func TestVolCreateValidation(t *testing.T) {
r, err := New(t.TempDir(), idtools.Identity{UID: os.Geteuid(), GID: os.Getegid()})
if err != nil {
t.Fatal(err)
}
mandatoryOpts = map[string][]string{
"device": {"type"},
"type": {"device"},
"o": {"device", "type"},
}
tests := []struct {
doc string
name string
opts map[string]string
expectedErr string
}{
{
doc: "invalid: name too short",
name: "a",
opts: map[string]string{
"type": "foo",
"device": "foo",
},
expectedErr: `volume name is too short, names should be at least two alphanumeric characters`,
},
{
doc: "invalid: name invalid characters",
name: "hello world",
opts: map[string]string{
"type": "foo",
"device": "foo",
},
expectedErr: `"hello world" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path`,
},
{
doc: "invalid: size, but no quotactl",
opts: map[string]string{"size": "1234"},
expectedErr: `quota size requested but no quota support`,
},
{
doc: "invalid: device without type",
opts: map[string]string{
"device": "foo",
},
expectedErr: `missing required option: "type"`,
},
{
doc: "invalid: type without device",
opts: map[string]string{
"type": "foo",
},
expectedErr: `missing required option: "device"`,
},
{
doc: "invalid: o without device",
opts: map[string]string{
"o": "foo",
"type": "foo",
},
expectedErr: `missing required option: "device"`,
},
{
doc: "invalid: o without type",
opts: map[string]string{
"o": "foo",
"device": "foo",
},
expectedErr: `missing required option: "type"`,
},
{
doc: "valid: short name, no options",
name: "ab",
},
{
doc: "valid: device and type",
opts: map[string]string{
"type": "foo",
"device": "foo",
},
},
{
doc: "valid: device, type, and o",
opts: map[string]string{
"type": "foo",
"device": "foo",
"o": "foo",
},
},
}
for i, tc := range tests {
tc := tc
t.Run(tc.doc, func(t *testing.T) {
if tc.name == "" {
tc.name = "vol-" + strconv.Itoa(i)
}
v, err := r.Create(tc.name, tc.opts)
if v != nil {
defer assert.Check(t, r.Remove(v))
}
if tc.expectedErr == "" {
assert.NilError(t, err)
} else {
assert.Check(t, errdefs.IsInvalidParameter(err), "got: %T", err)
assert.ErrorContains(t, err, tc.expectedErr)
}
})
}
}