kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Don't read CPU usage if there is no subscribers for stats

Browse source 
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
This commit is contained in:
Alexander Morozov 2015-09-08 11:57:22 -07:00
parent a8d6b033e1
commit c486a3a6dc
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
daemon/stats_collector_unix.go
View file

@ -89,12 +89,6 @@ func (s *statsCollector) run() {
var pairs []publishersPair var pairs []publishersPair
for range time.Tick(s.interval) { for range time.Tick(s.interval) {
systemUsage, err := s.getSystemCPUUsage()
if err != nil {
logrus.Errorf("collecting system cpu usage: %v", err)
continue
}
// it does not make sense in the first iteration, // it does not make sense in the first iteration,
// but saves allocations in further iterations // but saves allocations in further iterations
pairs = pairs[:0] pairs = pairs[:0]
@ -105,6 +99,15 @@ func (s *statsCollector) run() {
pairs = append(pairs, publishersPair{container, publisher}) pairs = append(pairs, publishersPair{container, publisher})
} }
s.m.Unlock() s.m.Unlock()
if len(pairs) == 0 {
continue
}
systemUsage, err := s.getSystemCPUUsage()
if err != nil {
logrus.Errorf("collecting system cpu usage: %v", err)
continue
}
for _, pair := range pairs { for _, pair := range pairs {
stats, err := pair.container.stats() stats, err := pair.container.stats()