diff --git a/daemon/info_unix.go b/daemon/info_unix.go index 98935cca70..55b6c6e79b 100644 --- a/daemon/info_unix.go +++ b/daemon/info_unix.go @@ -29,7 +29,6 @@ func (daemon *Daemon) fillPlatformInfo(v *types.Info, sysInfo *sysinfo.SysInfo) v.DefaultRuntime = daemon.configStore.GetDefaultRuntimeName() v.InitBinary = daemon.configStore.GetInitPath() - v.RuncCommit.Expected = dockerversion.RuncCommitID defaultRuntimeBinary := daemon.configStore.GetRuntime(v.DefaultRuntime).Path if rv, err := exec.Command(defaultRuntimeBinary, "--version").Output(); err == nil { parts := strings.Split(strings.TrimSpace(string(rv)), "\n") @@ -49,7 +48,10 @@ func (daemon *Daemon) fillPlatformInfo(v *types.Info, sysInfo *sysinfo.SysInfo) v.RuncCommit.ID = "N/A" } - v.ContainerdCommit.Expected = dockerversion.ContainerdCommitID + // runc is now shipped as a separate package. Set "expected" to same value + // as "ID" to prevent clients from reporting a version-mismatch + v.RuncCommit.Expected = v.RuncCommit.ID + if rv, err := daemon.containerd.Version(context.Background()); err == nil { v.ContainerdCommit.ID = rv.Revision } else { @@ -57,6 +59,10 @@ func (daemon *Daemon) fillPlatformInfo(v *types.Info, sysInfo *sysinfo.SysInfo) v.ContainerdCommit.ID = "N/A" } + // containerd is now shipped as a separate package. Set "expected" to same + // value as "ID" to prevent clients from reporting a version-mismatch + v.ContainerdCommit.Expected = v.ContainerdCommit.ID + defaultInitBinary := daemon.configStore.GetInitPath() if rv, err := exec.Command(defaultInitBinary, "--version").Output(); err == nil { ver, err := parseInitVersion(string(rv)) diff --git a/dockerversion/version_lib.go b/dockerversion/version_lib.go index 17b6990cc9..b7d4650444 100644 --- a/dockerversion/version_lib.go +++ b/dockerversion/version_lib.go @@ -10,8 +10,6 @@ const ( Version = "library-import" BuildTime = "library-import" IAmStatic = "library-import" - ContainerdCommitID = "library-import" - RuncCommitID = "library-import" InitCommitID = "library-import" PlatformName = "" ProductName = "" diff --git a/hack/make/.go-autogen b/hack/make/.go-autogen index 9bdc1f379d..6397cdc2d3 100644 --- a/hack/make/.go-autogen +++ b/hack/make/.go-autogen @@ -19,7 +19,6 @@ const ( Version string = "$VERSION" BuildTime string = "$BUILDTIME" IAmStatic string = "${IAMSTATIC:-true}" - ContainerdCommitID string = "${CONTAINERD_COMMIT}" PlatformName string = "${PLATFORM}" ProductName string = "${PRODUCT}" DefaultProductLicense string = "${DEFAULT_PRODUCT_LICENSE}" @@ -37,7 +36,6 @@ package dockerversion // Default build-time variable for library-import. // This file is overridden on build with build-time information. const ( - RuncCommitID string = "${RUNC_COMMIT}" InitCommitID string = "${TINI_COMMIT}" )