mirror of
				https://github.com/moby/moby.git
				synced 2022-11-09 12:21:53 -05:00 
			
		
		
		
	tlsconfig: better format for error message in tlsconfig
Signed-off-by: Tibor Vass <tibor@docker.com>
This commit is contained in:
		
							parent
							
								
									bfccd328be
								
							
						
					
					
						commit
						c7a04fda2a
					
				
					 2 changed files with 5 additions and 5 deletions
				
			
		| 
						 | 
				
			
			@ -228,7 +228,7 @@ func (cli *DaemonCli) CmdDaemon(args ...string) error {
 | 
			
		|||
		}
 | 
			
		||||
		tlsConfig, err := tlsconfig.Server(*commonFlags.TLSOptions)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			logrus.Fatalf("foobar: %v", err)
 | 
			
		||||
			logrus.Fatal(err)
 | 
			
		||||
		}
 | 
			
		||||
		serverConfig.TLSConfig = tlsConfig
 | 
			
		||||
	}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -72,10 +72,10 @@ func certPool(caFile string) (*x509.CertPool, error) {
 | 
			
		|||
	certPool := x509.NewCertPool()
 | 
			
		||||
	pem, err := ioutil.ReadFile(caFile)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return nil, fmt.Errorf("Could not read CA certificate %s: %v", caFile, err)
 | 
			
		||||
		return nil, fmt.Errorf("Could not read CA certificate %q: %v", caFile, err)
 | 
			
		||||
	}
 | 
			
		||||
	if !certPool.AppendCertsFromPEM(pem) {
 | 
			
		||||
		return nil, fmt.Errorf("failed to append certificates from PEM file: %s", caFile)
 | 
			
		||||
		return nil, fmt.Errorf("failed to append certificates from PEM file: %q", caFile)
 | 
			
		||||
	}
 | 
			
		||||
	s := certPool.Subjects()
 | 
			
		||||
	subjects := make([]string, len(s))
 | 
			
		||||
| 
						 | 
				
			
			@ -116,9 +116,9 @@ func Server(options Options) (*tls.Config, error) {
 | 
			
		|||
	tlsCert, err := tls.LoadX509KeyPair(options.CertFile, options.KeyFile)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		if os.IsNotExist(err) {
 | 
			
		||||
			return nil, fmt.Errorf("Could not load X509 key pair (%s, %s): %v", options.CertFile, options.KeyFile, err)
 | 
			
		||||
			return nil, fmt.Errorf("Could not load X509 key pair (cert: %q, key: %q): %v", options.CertFile, options.KeyFile, err)
 | 
			
		||||
		}
 | 
			
		||||
		return nil, fmt.Errorf("Error reading X509 key pair (%s, %s): %v. Make sure the key is not encrypted.", options.CertFile, options.KeyFile, err)
 | 
			
		||||
		return nil, fmt.Errorf("Error reading X509 key pair (cert: %q, key: %q): %v. Make sure the key is not encrypted.", options.CertFile, options.KeyFile, err)
 | 
			
		||||
	}
 | 
			
		||||
	tlsConfig.Certificates = []tls.Certificate{tlsCert}
 | 
			
		||||
	if options.ClientAuth >= tls.VerifyClientCertIfGiven {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue