kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity

Merge pull request #25144 from dnephin/remove-extraneous-aliases.bump 

[bump_v1.12.0] Remove extraneous mount aliases
This commit is contained in:
Tibor Vass 2016-07-27 14:13:49 -07:00 committed by GitHub
parent 340ff060a8 398bde913f
commit c9b38547d5
2 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
api/client/service/opts.go
View File

@ -178,12 +178,11 @@ func (m *MountOpt) Set(value string) error {
key := strings.ToLower(parts[0])
if len(parts) == 1 {
if key == "readonly" || key == "ro" {
switch key {
case "readonly", "ro":
mount.ReadOnly = true
continue
}
if key == "volume-nocopy" {
case "volume-nocopy":
volumeOptions().NoCopy = true
continue
}
@ -197,16 +196,15 @@ func (m *MountOpt) Set(value string) error {
switch key {
case "type":
mount.Type = swarm.MountType(strings.ToLower(value))
case "source", "name", "src":
case "source", "src":
mount.Source = value
case "target", "dst", "dest", "destination", "path":
case "target", "dst", "destination":
mount.Target = value
case "readonly", "ro":
ro, err := strconv.ParseBool(value)
mount.ReadOnly, err = strconv.ParseBool(value)
if err != nil {
return fmt.Errorf("invalid value for readonly: %s", value)
return fmt.Errorf("invalid value for %s: %s", key, value)
}
mount.ReadOnly = ro
case "bind-propagation":
bindOptions().Propagation = swarm.MountPropagation(strings.ToLower(value))
case "volume-nocopy":

4
api/client/service/opts_test.go
View File

@ -81,8 +81,8 @@ func TestMountOptSetNoError(t *testing.T) {
// tests several aliases that should have same result.
"type=bind,target=/target,source=/source",
"type=bind,src=/source,dst=/target",
"type=bind,name=/source,dst=/target",
"type=bind,name=/source,path=/target",
"type=bind,source=/source,dst=/target",
"type=bind,src=/source,target=/target",
} {
var mount MountOpt