From cc3e59c44e997c6c399415d1378072f247129230 Mon Sep 17 00:00:00 2001 From: John Howard Date: Wed, 4 Jan 2017 16:17:55 -0800 Subject: [PATCH] Windows: Fix old TP5 volume unit tests Signed-off-by: John Howard --- volume/volume_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/volume/volume_test.go b/volume/volume_test.go index 54df38053f..426e6e5c16 100644 --- a/volume/volume_test.go +++ b/volume/volume_test.go @@ -22,7 +22,6 @@ func TestParseMountRaw(t *testing.T) { `d:`, `d:\path`, `d:\path with space`, - // TODO Windows post TP5 - readonly support `d:\pathandmode:ro`, `c:\:d:\`, `c:\windows\:d:`, `c:\windows:d:\s p a c e`, @@ -33,9 +32,9 @@ func TestParseMountRaw(t *testing.T) { `name:D:`, `name:D::rW`, `name:D::RW`, - // TODO Windows post TP5 - readonly support `name:D::RO`, + `name:D::RO`, `c:/:d:/forward/slashes/are/good/too`, - // TODO Windows post TP5 - readonly support `c:/:d:/including with/spaces:ro`, + `c:/:d:/including with/spaces:ro`, `c:\Windows`, // With capital `c:\Program Files (x86)`, // With capitals and brackets } @@ -59,6 +58,7 @@ func TestParseMountRaw(t *testing.T) { `name?:d:`: `invalid volume specification`, `name/:d:`: `invalid volume specification`, `d:\pathandmode:rw`: `invalid volume specification`, + `d:\pathandmode:ro`: `invalid volume specification`, `con:d:`: `cannot be a reserved word for Windows filenames`, `PRN:d:`: `cannot be a reserved word for Windows filenames`, `aUx:d:`: `cannot be a reserved word for Windows filenames`, @@ -157,12 +157,12 @@ func TestParseMountRawSplit(t *testing.T) { cases = []testParseMountRaw{ {`c:\:d:`, "local", `d:`, `c:\`, ``, "", true, false}, {`c:\:d:\`, "local", `d:\`, `c:\`, ``, "", true, false}, - // TODO Windows post TP5 - Add readonly support {`c:\:d:\:ro`, "local", `d:\`, `c:\`, ``, "", false, false}, + {`c:\:d:\:ro`, "local", `d:\`, `c:\`, ``, "", false, false}, {`c:\:d:\:rw`, "local", `d:\`, `c:\`, ``, "", true, false}, {`c:\:d:\:foo`, "local", `d:\`, `c:\`, ``, "", false, true}, {`name:d::rw`, "local", `d:`, ``, `name`, "local", true, false}, {`name:d:`, "local", `d:`, ``, `name`, "local", true, false}, - // TODO Windows post TP5 - Add readonly support {`name:d::ro`, "local", `d:`, ``, `name`, "local", false, false}, + {`name:d::ro`, "local", `d:`, ``, `name`, "local", false, false}, {`name:c:`, "", ``, ``, ``, "", true, true}, {`driver/name:c:`, "", ``, ``, ``, "", true, true}, }