From d216db6ef24d989950af88a20f0e50ef3f19ad5f Mon Sep 17 00:00:00 2001 From: David Calavera Date: Wed, 2 Sep 2015 11:18:01 +0200 Subject: [PATCH] Do not print the word `nil` in a log. Because it doesn't mean anything. Signed-off-by: David Calavera --- libnetwork/osl/namespace_linux.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libnetwork/osl/namespace_linux.go b/libnetwork/osl/namespace_linux.go index 21619ed934..55e57a1fa2 100644 --- a/libnetwork/osl/namespace_linux.go +++ b/libnetwork/osl/namespace_linux.go @@ -244,13 +244,8 @@ func (n *networkNamespace) InvokeFunc(f func()) error { }) } -func getLink() string { - l, err := os.Readlink(fmt.Sprintf("/proc/%d/task/%d/ns/net", os.Getpid(), syscall.Gettid())) - if err != nil { - return fmt.Sprintf("(nil: %v)", err) - } - - return l +func getLink() (string, error) { + return os.Readlink(fmt.Sprintf("/proc/%d/task/%d/ns/net", os.Getpid(), syscall.Gettid())) } func nsInit() { @@ -266,8 +261,13 @@ func InitOSContext() func() { runtime.LockOSThread() nsOnce.Do(nsInit) if err := netns.Set(initNs); err != nil { - log.Errorf("failed to set to initial namespace, link %s, initns fd %d: %v", - getLink(), initNs, err) + linkInfo, linkErr := getLink() + if linkErr != nil { + linkInfo = linkErr.Error() + } + + log.Errorf("failed to set to initial namespace, %v, initns fd %d: %v", + linkInfo, initNs, err) } return runtime.UnlockOSThread