From 0eed34755e3493dbb6204cb378228e72750609e5 Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Mon, 25 Jan 2016 15:44:59 -0500 Subject: [PATCH] Fix removing mountpoints on container rm fail Ensure that the the container's mountpoints are cleaned up if the container is force removed. Signed-off-by: Brian Goff --- daemon/delete.go | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/daemon/delete.go b/daemon/delete.go index c8be1bc506..a086aed616 100644 --- a/daemon/delete.go +++ b/daemon/delete.go @@ -43,15 +43,14 @@ func (daemon *Daemon) ContainerRm(name string, config *types.ContainerRmConfig) return daemon.rmLink(container, name) } - if err := daemon.cleanupContainer(container, config.ForceRemove); err != nil { - return err + err = daemon.cleanupContainer(container, config.ForceRemove) + if err == nil || config.ForceRemove { + if e := daemon.removeMountPoints(container, config.RemoveVolume); e != nil { + logrus.Error(e) + } } - if err := daemon.removeMountPoints(container, config.RemoveVolume); err != nil { - logrus.Error(err) - } - - return nil + return err } func (daemon *Daemon) rmLink(container *container.Container, name string) error {