From d787f2731e4242f244e88f047032ad9650f1f8d7 Mon Sep 17 00:00:00 2001 From: Sridhar Ratnakumar Date: Thu, 15 May 2014 21:36:15 -0700 Subject: [PATCH] fix panic when passing empty environment Docker-DCO-1.1-Signed-off-by: Sridhar Ratnakumar (github: srid) --- pkg/libcontainer/nsinit/init.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/libcontainer/nsinit/init.go b/pkg/libcontainer/nsinit/init.go index 3bbcfcc654..af60d739ca 100644 --- a/pkg/libcontainer/nsinit/init.go +++ b/pkg/libcontainer/nsinit/init.go @@ -152,6 +152,9 @@ func LoadContainerEnvironment(container *libcontainer.Container) error { os.Clearenv() for _, pair := range container.Env { p := strings.SplitN(pair, "=", 2) + if len(p) < 2 { + return fmt.Errorf("invalid environment '%v'", pair) + } if err := os.Setenv(p[0], p[1]); err != nil { return err }