mirror of
				https://github.com/moby/moby.git
				synced 2022-11-09 12:21:53 -05:00 
			
		
		
		
	Clean output and simplify hack/make/*test by adding go_test_dir function in make.sh
This commit is contained in:
		
							parent
							
								
									416b16e1e2
								
							
						
					
					
						commit
						dcfc4ada4d
					
				
					 3 changed files with 27 additions and 28 deletions
				
			
		
							
								
								
									
										18
									
								
								hack/make.sh
									
										
									
									
									
								
							
							
						
						
									
										18
									
								
								hack/make.sh
									
										
									
									
									
								
							| 
						 | 
					@ -62,6 +62,24 @@ LDFLAGS='-X main.GITCOMMIT "'$GITCOMMIT'" -X main.VERSION "'$VERSION'" -w'
 | 
				
			||||||
LDFLAGS_STATIC='-X github.com/dotcloud/docker/utils.IAMSTATIC true -linkmode external -extldflags "-lpthread -static -Wl,--unresolved-symbols=ignore-in-object-files"'
 | 
					LDFLAGS_STATIC='-X github.com/dotcloud/docker/utils.IAMSTATIC true -linkmode external -extldflags "-lpthread -static -Wl,--unresolved-symbols=ignore-in-object-files"'
 | 
				
			||||||
BUILDFLAGS='-tags netgo'
 | 
					BUILDFLAGS='-tags netgo'
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					# If $TESTFLAGS is set in the environment, it is passed as extra arguments to 'go test'.
 | 
				
			||||||
 | 
					# You can use this to select certain tests to run, eg.
 | 
				
			||||||
 | 
					#
 | 
				
			||||||
 | 
					#   TESTFLAGS='-run ^TestBuild$' ./hack/make.sh test
 | 
				
			||||||
 | 
					#
 | 
				
			||||||
 | 
					go_test_dir() {
 | 
				
			||||||
 | 
						dir=$1
 | 
				
			||||||
 | 
						( # we run "go test -i" ouside the "set -x" to provde cleaner output
 | 
				
			||||||
 | 
							cd "$dir"
 | 
				
			||||||
 | 
							go test -i -ldflags "$LDFLAGS" $BUILDFLAGS
 | 
				
			||||||
 | 
						)
 | 
				
			||||||
 | 
						(
 | 
				
			||||||
 | 
							set -x
 | 
				
			||||||
 | 
							cd "$dir"
 | 
				
			||||||
 | 
							go test -ldflags "$LDFLAGS" $BUILDFLAGS $TESTFLAGS
 | 
				
			||||||
 | 
						)
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
bundle() {
 | 
					bundle() {
 | 
				
			||||||
	bundlescript=$1
 | 
						bundlescript=$1
 | 
				
			||||||
	bundle=$(basename $bundlescript)
 | 
						bundle=$(basename $bundlescript)
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -17,29 +17,20 @@ GREEN=$'\033[32m'
 | 
				
			||||||
# Run Docker's test suite, including sub-packages, and store their output as a bundle
 | 
					# Run Docker's test suite, including sub-packages, and store their output as a bundle
 | 
				
			||||||
# If $TESTFLAGS is set in the environment, it is passed as extra arguments to 'go test'.
 | 
					# If $TESTFLAGS is set in the environment, it is passed as extra arguments to 'go test'.
 | 
				
			||||||
# You can use this to select certain tests to run, eg.
 | 
					# You can use this to select certain tests to run, eg.
 | 
				
			||||||
# 
 | 
					#
 | 
				
			||||||
# 	TESTFLAGS='-run ^TestBuild$' ./hack/make.sh test
 | 
					#   TESTFLAGS='-run ^TestBuild$' ./hack/make.sh test
 | 
				
			||||||
#
 | 
					#
 | 
				
			||||||
bundle_test() {
 | 
					bundle_test() {
 | 
				
			||||||
	{
 | 
						{
 | 
				
			||||||
		date
 | 
							date
 | 
				
			||||||
		
 | 
					
 | 
				
			||||||
 | 
							export TEST_DOCKERINIT_PATH=$DEST/../dynbinary/dockerinit-$VERSION
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		TESTS_FAILED=()
 | 
							TESTS_FAILED=()
 | 
				
			||||||
		for test_dir in $(find_test_dirs); do
 | 
							for test_dir in $(find_test_dirs); do
 | 
				
			||||||
			echo
 | 
								echo
 | 
				
			||||||
			
 | 
					
 | 
				
			||||||
			if ! (
 | 
								if ! LDFLAGS="$LDFLAGS -X github.com/dotcloud/docker/utils.INITSHA1 \"$DOCKER_INITSHA1\"" go_test_dir "$test_dir"; then
 | 
				
			||||||
				set -x
 | 
					 | 
				
			||||||
				cd $test_dir
 | 
					 | 
				
			||||||
				
 | 
					 | 
				
			||||||
				# Install packages that are dependencies of the tests.
 | 
					 | 
				
			||||||
				#   Note: Does not run the tests.
 | 
					 | 
				
			||||||
				go test -i -ldflags "$LDFLAGS" $BUILDFLAGS
 | 
					 | 
				
			||||||
				
 | 
					 | 
				
			||||||
				# Run the tests with the optional $TESTFLAGS.
 | 
					 | 
				
			||||||
				export TEST_DOCKERINIT_PATH=$DEST/../dynbinary/dockerinit-$VERSION
 | 
					 | 
				
			||||||
				go test -ldflags "$LDFLAGS -X github.com/dotcloud/docker/utils.INITSHA1 \"$DOCKER_INITSHA1\"" $BUILDFLAGS $TESTFLAGS
 | 
					 | 
				
			||||||
			); then
 | 
					 | 
				
			||||||
				TESTS_FAILED+=("$test_dir")
 | 
									TESTS_FAILED+=("$test_dir")
 | 
				
			||||||
				echo
 | 
									echo
 | 
				
			||||||
				echo "${RED}Tests failed: $test_dir${TEXTRESET}"
 | 
									echo "${RED}Tests failed: $test_dir${TEXTRESET}"
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -12,7 +12,7 @@ GREEN=$'\033[32m'
 | 
				
			||||||
# If $TESTFLAGS is set in the environment, it is passed as extra arguments to 'go test'.
 | 
					# If $TESTFLAGS is set in the environment, it is passed as extra arguments to 'go test'.
 | 
				
			||||||
# You can use this to select certain tests to run, eg.
 | 
					# You can use this to select certain tests to run, eg.
 | 
				
			||||||
#
 | 
					#
 | 
				
			||||||
# 	TESTFLAGS='-run ^TestBuild$' ./hack/make.sh test
 | 
					#   TESTFLAGS='-run ^TestBuild$' ./hack/make.sh test
 | 
				
			||||||
#
 | 
					#
 | 
				
			||||||
bundle_test() {
 | 
					bundle_test() {
 | 
				
			||||||
	{
 | 
						{
 | 
				
			||||||
| 
						 | 
					@ -22,17 +22,7 @@ bundle_test() {
 | 
				
			||||||
		for test_dir in $(find_test_dirs); do
 | 
							for test_dir in $(find_test_dirs); do
 | 
				
			||||||
			echo
 | 
								echo
 | 
				
			||||||
 | 
					
 | 
				
			||||||
			if ! (
 | 
								if ! LDFLAGS="$LDFLAGS $LDFLAGS_STATIC" go_test_dir "$test_dir"; then
 | 
				
			||||||
				set -x
 | 
					 | 
				
			||||||
				cd $test_dir
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
				# Install packages that are dependencies of the tests.
 | 
					 | 
				
			||||||
				#   Note: Does not run the tests.
 | 
					 | 
				
			||||||
				go test -i -ldflags "$LDFLAGS $LDFLAGS_STATIC" $BUILDFLAGS
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
				# Run the tests with the optional $TESTFLAGS.
 | 
					 | 
				
			||||||
				go test -ldflags "$LDFLAGS $LDFLAGS_STATIC" $BUILDFLAGS $TESTFLAGS
 | 
					 | 
				
			||||||
			); then
 | 
					 | 
				
			||||||
				TESTS_FAILED+=("$test_dir")
 | 
									TESTS_FAILED+=("$test_dir")
 | 
				
			||||||
				echo
 | 
									echo
 | 
				
			||||||
				echo "${RED}Tests failed: $test_dir${TEXTRESET}"
 | 
									echo "${RED}Tests failed: $test_dir${TEXTRESET}"
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue