From dd01abf9bf73ceab048464b8d5ee1358adfec800 Mon Sep 17 00:00:00 2001 From: Roman Volosatovs Date: Thu, 22 Jul 2021 22:41:01 +0200 Subject: [PATCH] integration: copy loop variable into parallel test closures Discovered a few instances, where loop variable is incorrectly used within a test closure, which is marked as parallel. Few of these were actually loops over singleton slices, therefore the issue might not have surfaced there (yet), but it is good to fix there as well, as this is an incorrect pattern used across different tests. Signed-off-by: Roman Volosatovs --- integration/container/container_test.go | 1 + integration/network/network_test.go | 2 ++ integration/plugin/common/plugin_test.go | 1 + integration/volume/volume_test.go | 1 + 4 files changed, 5 insertions(+) diff --git a/integration/container/container_test.go b/integration/container/container_test.go index 86e02d9faa..60c0e12443 100644 --- a/integration/container/container_test.go +++ b/integration/container/container_test.go @@ -19,6 +19,7 @@ func TestContainerInvalidJSON(t *testing.T) { } for _, ep := range endpoints { + ep := ep t.Run(ep, func(t *testing.T) { t.Parallel() diff --git a/integration/network/network_test.go b/integration/network/network_test.go index a4057d2410..66fdcfe26a 100644 --- a/integration/network/network_test.go +++ b/integration/network/network_test.go @@ -72,6 +72,7 @@ func TestNetworkInvalidJSON(t *testing.T) { } for _, ep := range endpoints { + ep := ep t.Run(ep, func(t *testing.T) { t.Parallel() @@ -105,6 +106,7 @@ func TestNetworkList(t *testing.T) { } for _, ep := range endpoints { + ep := ep t.Run(ep, func(t *testing.T) { t.Parallel() diff --git a/integration/plugin/common/plugin_test.go b/integration/plugin/common/plugin_test.go index a5568cca91..83e060f82e 100644 --- a/integration/plugin/common/plugin_test.go +++ b/integration/plugin/common/plugin_test.go @@ -36,6 +36,7 @@ func TestPluginInvalidJSON(t *testing.T) { endpoints := []string{"/plugins/foobar/set"} for _, ep := range endpoints { + ep := ep t.Run(ep, func(t *testing.T) { t.Parallel() diff --git a/integration/volume/volume_test.go b/integration/volume/volume_test.go index 65f457d6d8..f465e47b05 100644 --- a/integration/volume/volume_test.go +++ b/integration/volume/volume_test.go @@ -110,6 +110,7 @@ func TestVolumesInvalidJSON(t *testing.T) { endpoints := []string{"/volumes/create"} for _, ep := range endpoints { + ep := ep t.Run(ep, func(t *testing.T) { t.Parallel()