kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Improved message when pushing a non-existant image

Browse source 
The prior error message caused confusion.  If a user attempts to push an
image up to a registry, but they misspelled (or forgot to properly tag
their image) they would see the message 'Repository does not exist', which
is not very clear and causes some to think that there might be a problem
with the registry or connectivity to it, when the problem was simply just
that an image with that tag specified does not exist locally.

Signed-off-by: Dave MacDonald <mindlapse@gmail.com>
This commit is contained in:
Dave MacDonald 2016-04-03 16:25:07 -04:00
parent 8eb8a1d6b8
commit e57900a269
No known key found for this signature in database
GPG key ID: 76ADBF3C47E773E5
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
distribution/push.go
View file

@ -109,7 +109,7 @@ func Push(ctx context.Context, ref reference.Named, imagePushConfig *ImagePushCo
associations := imagePushConfig.ReferenceStore.ReferencesByName(repoInfo) associations := imagePushConfig.ReferenceStore.ReferencesByName(repoInfo)
if len(associations) == 0 { if len(associations) == 0 {
return fmt.Errorf("Repository does not exist: %s", repoInfo.Name()) return fmt.Errorf("An image does not exist locally with the tag: %s", repoInfo.Name())
} }
var ( var (

2
integration-cli/docker_cli_push_test.go
View file

@ -43,7 +43,7 @@ func (s *DockerSuite) TestPushUnprefixedRepo(c *check.C) {
func testPushUntagged(c *check.C) { func testPushUntagged(c *check.C) {
repoName := fmt.Sprintf("%v/dockercli/busybox", privateRegistryURL) repoName := fmt.Sprintf("%v/dockercli/busybox", privateRegistryURL)
expected := "Repository does not exist" expected := "An image does not exist locally with the tag"
out, _, err := dockerCmdWithError("push", repoName) out, _, err := dockerCmdWithError("push", repoName)
c.Assert(err, check.NotNil, check.Commentf("pushing the image to the private registry should have failed: output %q", out)) c.Assert(err, check.NotNil, check.Commentf("pushing the image to the private registry should have failed: output %q", out))