gosec: G601: Implicit memory aliasing in for loop
plugin/v2/plugin.go:141:50: G601: Implicit memory aliasing in for loop. (gosec)
updateSettingsEnv(&p.PluginObj.Settings.Env, &s)
^
libcontainerd/remote/client.go:572:13: G601: Implicit memory aliasing in for loop. (gosec)
cpDesc = &m
^
distribution/push_v2.go:400:34: G601: Implicit memory aliasing in for loop. (gosec)
(metadata.CheckV2MetadataHMAC(&mountCandidate, pd.hmacKey) ||
^
builder/dockerfile/builder.go:261:84: G601: Implicit memory aliasing in for loop. (gosec)
currentCommandIndex = printCommand(b.Stdout, currentCommandIndex, totalCommands, &meta)
^
builder/dockerfile/builder.go:278:46: G601: Implicit memory aliasing in for loop. (gosec)
if err := initializeStage(dispatchRequest, &stage); err != nil {
^
daemon/container.go:283:40: G601: Implicit memory aliasing in for loop. (gosec)
if err := parser.ValidateMountConfig(&cfg); err != nil {
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit d13997b4ba
)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
parent
2ddf6e598a
commit
e8b838e99f
|
@ -257,10 +257,10 @@ func (b *Builder) dispatchDockerfileWithCancellation(parseResult []instructions.
|
||||||
totalCommands += len(stage.Commands)
|
totalCommands += len(stage.Commands)
|
||||||
}
|
}
|
||||||
shlex := shell.NewLex(escapeToken)
|
shlex := shell.NewLex(escapeToken)
|
||||||
for _, meta := range metaArgs {
|
for i := range metaArgs {
|
||||||
currentCommandIndex = printCommand(b.Stdout, currentCommandIndex, totalCommands, &meta)
|
currentCommandIndex = printCommand(b.Stdout, currentCommandIndex, totalCommands, &metaArgs[i])
|
||||||
|
|
||||||
err := processMetaArg(meta, shlex, buildArgs)
|
err := processMetaArg(metaArgs[i], shlex, buildArgs)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
@ -268,7 +268,8 @@ func (b *Builder) dispatchDockerfileWithCancellation(parseResult []instructions.
|
||||||
|
|
||||||
stagesResults := newStagesBuildResults()
|
stagesResults := newStagesBuildResults()
|
||||||
|
|
||||||
for _, stage := range parseResult {
|
for _, s := range parseResult {
|
||||||
|
stage := s
|
||||||
if err := stagesResults.checkStageNameAvailable(stage.Name); err != nil {
|
if err := stagesResults.checkStageNameAvailable(stage.Name); err != nil {
|
||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
|
@ -279,7 +279,8 @@ func validateHostConfig(hostConfig *containertypes.HostConfig, platform string)
|
||||||
}
|
}
|
||||||
// Validate mounts; check if host directories still exist
|
// Validate mounts; check if host directories still exist
|
||||||
parser := volumemounts.NewParser(platform)
|
parser := volumemounts.NewParser(platform)
|
||||||
for _, cfg := range hostConfig.Mounts {
|
for _, c := range hostConfig.Mounts {
|
||||||
|
cfg := c
|
||||||
if err := parser.ValidateMountConfig(&cfg); err != nil {
|
if err := parser.ValidateMountConfig(&cfg); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
|
@ -330,7 +330,8 @@ func (pd *v2PushDescriptor) Upload(ctx context.Context, progressOutput progress.
|
||||||
// Attempt to find another repository in the same registry to mount the layer from to avoid an unnecessary upload
|
// Attempt to find another repository in the same registry to mount the layer from to avoid an unnecessary upload
|
||||||
candidates := getRepositoryMountCandidates(pd.repoInfo, pd.hmacKey, maxMountAttempts, v2Metadata)
|
candidates := getRepositoryMountCandidates(pd.repoInfo, pd.hmacKey, maxMountAttempts, v2Metadata)
|
||||||
isUnauthorizedError := false
|
isUnauthorizedError := false
|
||||||
for _, mountCandidate := range candidates {
|
for _, mc := range candidates {
|
||||||
|
mountCandidate := mc
|
||||||
logrus.Debugf("attempting to mount layer %s (%s) from %s", diffID, mountCandidate.Digest, mountCandidate.SourceRepository)
|
logrus.Debugf("attempting to mount layer %s (%s) from %s", diffID, mountCandidate.Digest, mountCandidate.SourceRepository)
|
||||||
createOpts := []distribution.BlobCreateOption{}
|
createOpts := []distribution.BlobCreateOption{}
|
||||||
|
|
||||||
|
|
|
@ -568,6 +568,7 @@ func (c *client) CreateCheckpoint(ctx context.Context, containerID, checkpointDi
|
||||||
|
|
||||||
var cpDesc *v1.Descriptor
|
var cpDesc *v1.Descriptor
|
||||||
for _, m := range index.Manifests {
|
for _, m := range index.Manifests {
|
||||||
|
m := m
|
||||||
if m.MediaType == images.MediaTypeContainerd1Checkpoint {
|
if m.MediaType == images.MediaTypeContainerd1Checkpoint {
|
||||||
cpDesc = &m
|
cpDesc = &m
|
||||||
break
|
break
|
||||||
|
|
|
@ -126,7 +126,9 @@ func (p *Plugin) Set(args []string) error {
|
||||||
// TODO(vieux): lots of code duplication here, needs to be refactored.
|
// TODO(vieux): lots of code duplication here, needs to be refactored.
|
||||||
|
|
||||||
next:
|
next:
|
||||||
for _, s := range sets {
|
for _, set := range sets {
|
||||||
|
s := set
|
||||||
|
|
||||||
// range over all the envs in the config
|
// range over all the envs in the config
|
||||||
for _, env := range p.PluginObj.Config.Env {
|
for _, env := range p.PluginObj.Config.Env {
|
||||||
// found the env in the config
|
// found the env in the config
|
||||||
|
|
Loading…
Reference in New Issue