kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

don't call sort for every add in history

Browse source 
This moves the call to sort in daemon/history to a function to be
called explicitly when we're done adding elements to the list.

This speeds up `docker ps`.

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (github: unclejack)
This commit is contained in:
unclejack 2014-05-14 14:17:58 +03:00
parent f637eaca5d
commit e963179c79
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
daemon/daemon.go
View file

@ -85,6 +85,7 @@ func (daemon *Daemon) List() []*Container {
for e := daemon.containers.Front(); e != nil; e = e.Next() { for e := daemon.containers.Front(); e != nil; e = e.Next() {
containers.Add(e.Value.(*Container)) containers.Add(e.Value.(*Container))
} }
containers.Sort()
return *containers return *containers
} }

3
daemon/history.go
View file

@ -26,5 +26,8 @@ func (history *History) Swap(i, j int) {
func (history *History) Add(container *Container) { func (history *History) Add(container *Container) {
*history = append(*history, container) *history = append(*history, container)
}
func (history *History) Sort() {
sort.Sort(history) sort.Sort(history)
} }