kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Add accept-permissions flag for install.

Browse source 
Signed-off-by: Anusha Ragunathan <anusha@docker.com>
This commit is contained in:
Anusha Ragunathan 2016-06-15 10:29:01 -07:00
parent 480d7b310b
commit ec4857da48
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
api/client/plugin/install.go
View file

@ -13,21 +13,31 @@ import (
"golang.org/x/net/context" "golang.org/x/net/context"
) )
type pluginOptions struct {
name string
grantPerms bool
}
func newInstallCommand(dockerCli *client.DockerCli) *cobra.Command { func newInstallCommand(dockerCli *client.DockerCli) *cobra.Command {
var options pluginOptions
cmd := &cobra.Command{ cmd := &cobra.Command{
Use: "install", Use: "install",
Short: "Install a plugin", Short: "Install a plugin",
Args: cli.RequiresMinArgs(1), // TODO: allow for set args Args: cli.RequiresMinArgs(1), // TODO: allow for set args
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
return runInstall(dockerCli, args[0], args[1:]) options.name = args[0]
return runInstall(dockerCli, options)
}, },
} }
flags := cmd.Flags()
flags.BoolVar(&options.grantPerms, "grant-permissions", true, "grant all permissions necessary to run the plugin")
return cmd return cmd
} }
func runInstall(dockerCli *client.DockerCli, name string, args []string) error { func runInstall(dockerCli *client.DockerCli, options pluginOptions) error {
named, err := reference.ParseNamed(name) // FIXME: validate named, err := reference.ParseNamed(options.name) // FIXME: validate
if err != nil { if err != nil {
return err return err
} }
@ -46,6 +56,6 @@ func runInstall(dockerCli *client.DockerCli, name string, args []string) error {
if err != nil { if err != nil {
return err return err
} }
// TODO: pass acceptAllPermissions and noEnable flag // TODO: pass noEnable flag
return dockerCli.Client().PluginInstall(ctx, ref.String(), encodedAuth, false, false, dockerCli.In(), dockerCli.Out()) return dockerCli.Client().PluginInstall(ctx, ref.String(), encodedAuth, options.grantPerms, false, dockerCli.In(), dockerCli.Out())
} }