From ed672bb523cb255d0b2b79837d9c45a7c3255000 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sat, 20 Jul 2019 10:32:08 +0200 Subject: [PATCH] Pin Dockerfile to -stretch variant MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Golang base images switch to buster, which causes some breakage in networking and packages that are no longer available; (`btrfs-tools` is now an empty package, and `libprotobuf-c0-dev` is gone). Some of out tests also start faiilng on stretch, and will have to be investigated further; ``` 15:13:06 --- FAIL: TestRenameAnonymousContainer (3.37s) 15:13:06 rename_test.go:168: assertion failed: 0 (int) != 1 (inspect.State.ExitCode int): container a7fe866d588d65f353f42ffc5ea5288e52700384e1d90850e9c3d4dce8657666 exited with the wrong exitcode: 15:13:38 --- FAIL: TestHostnameDnsResolution (2.23s) 15:13:38 run_linux_test.go:128: assertion failed: 15:13:38 --- ← 15:13:38 +++ → 15:13:38 @@ -1 +1,2 @@ 15:13:38 +ping: bad address 'foobar' 15:13:38 15:13:38 15:13:38 run_linux_test.go:129: assertion failed: 0 (int) != 1 (res.ExitCode int) ``` Signed-off-by: Sebastiaan van Stijn --- Dockerfile | 2 +- Dockerfile.simple | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index f0067793e7..824d0b9e07 100644 --- a/Dockerfile +++ b/Dockerfile @@ -27,7 +27,7 @@ ARG CROSS="false" ARG GO_VERSION=1.12.7 -FROM golang:${GO_VERSION} AS base +FROM golang:${GO_VERSION}-stretch AS base ARG APT_MIRROR RUN sed -ri "s/(httpredir|deb).debian.org/${APT_MIRROR:-deb.debian.org}/g" /etc/apt/sources.list \ && sed -ri "s/(security).debian.org/${APT_MIRROR:-security.debian.org}/g" /etc/apt/sources.list diff --git a/Dockerfile.simple b/Dockerfile.simple index d7b63ce9cc..ff64fa4f54 100644 --- a/Dockerfile.simple +++ b/Dockerfile.simple @@ -7,7 +7,7 @@ ARG GO_VERSION=1.12.7 -FROM golang:${GO_VERSION} +FROM golang:${GO_VERSION}-stretch # allow replacing httpredir or deb mirror ARG APT_MIRROR=deb.debian.org