mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
devmapper: Move base device creation in separate function
This moves base device creation function in a separate function. Pure code reorganization. Makes reading code little easier. Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
This commit is contained in:
parent
1529343a3f
commit
efc1ddd7e3
1 changed files with 34 additions and 25 deletions
|
@ -777,6 +777,38 @@ func (devices *DeviceSet) saveBaseDeviceUUID(baseInfo *devInfo) error {
|
|||
return nil
|
||||
}
|
||||
|
||||
func (devices *DeviceSet) createBaseImage() error {
|
||||
logrus.Debugf("Initializing base device-mapper thin volume")
|
||||
|
||||
// Create initial device
|
||||
info, err := devices.createRegisterDevice("")
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
logrus.Debugf("Creating filesystem on base device-mapper thin volume")
|
||||
|
||||
if err := devices.activateDeviceIfNeeded(info); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if err := devices.createFilesystem(info); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
info.Initialized = true
|
||||
if err := devices.saveMetadata(info); err != nil {
|
||||
info.Initialized = false
|
||||
return err
|
||||
}
|
||||
|
||||
if err := devices.saveBaseDeviceUUID(info); err != nil {
|
||||
return fmt.Errorf("Could not query and save base device UUID:%v", err)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
func (devices *DeviceSet) setupBaseImage() error {
|
||||
oldInfo, _ := devices.lookupDeviceWithLock("")
|
||||
if oldInfo != nil && oldInfo.Initialized {
|
||||
|
@ -817,34 +849,11 @@ func (devices *DeviceSet) setupBaseImage() error {
|
|||
}
|
||||
}
|
||||
|
||||
logrus.Debugf("Initializing base device-mapper thin volume")
|
||||
|
||||
// Create initial device
|
||||
info, err := devices.createRegisterDevice("")
|
||||
if err != nil {
|
||||
// Create new base image device
|
||||
if err := devices.createBaseImage(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
logrus.Debugf("Creating filesystem on base device-mapper thin volume")
|
||||
|
||||
if err := devices.activateDeviceIfNeeded(info); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if err := devices.createFilesystem(info); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
info.Initialized = true
|
||||
if err := devices.saveMetadata(info); err != nil {
|
||||
info.Initialized = false
|
||||
return err
|
||||
}
|
||||
|
||||
if err := devices.saveBaseDeviceUUID(info); err != nil {
|
||||
return fmt.Errorf("Could not query and save base device UUID:%v", err)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue