kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #40816 from thaJeztah/fix_api_version_handling

Browse source 
swarm: fix API version detection
This commit is contained in:
Tibor Vass 2020-04-15 13:17:26 -07:00 • committed by GitHub
commit f4b0673565
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
api/server/router/swarm/cluster_routes.go
View file

@ -225,15 +225,13 @@ func (sr *swarmRouter) createService(ctx context.Context, w http.ResponseWriter,
// Get returns "" if the header does not exist // Get returns "" if the header does not exist
encodedAuth := r.Header.Get("X-Registry-Auth") encodedAuth := r.Header.Get("X-Registry-Auth")
cliVersion := r.Header.Get("version")
queryRegistry := false queryRegistry := false
if cliVersion != "" { if v := httputils.VersionFromContext(ctx); v != "" {
if versions.LessThan(cliVersion, "1.30") { if versions.LessThan(v, "1.30") {
queryRegistry = true queryRegistry = true
} }
adjustForAPIVersion(cliVersion, &service) adjustForAPIVersion(v, &service)
} }
resp, err := sr.backend.CreateService(service, encodedAuth, queryRegistry) resp, err := sr.backend.CreateService(service, encodedAuth, queryRegistry)
if err != nil { if err != nil {
logrus.Errorf("Error creating service %s: %v", service.Name, err) logrus.Errorf("Error creating service %s: %v", service.Name, err)
@ -265,13 +263,12 @@ func (sr *swarmRouter) updateService(ctx context.Context, w http.ResponseWriter,
flags.EncodedRegistryAuth = r.Header.Get("X-Registry-Auth") flags.EncodedRegistryAuth = r.Header.Get("X-Registry-Auth")
flags.RegistryAuthFrom = r.URL.Query().Get("registryAuthFrom") flags.RegistryAuthFrom = r.URL.Query().Get("registryAuthFrom")
flags.Rollback = r.URL.Query().Get("rollback") flags.Rollback = r.URL.Query().Get("rollback")
cliVersion := r.Header.Get("version")
queryRegistry := false queryRegistry := false
if cliVersion != "" { if v := httputils.VersionFromContext(ctx); v != "" {
if versions.LessThan(cliVersion, "1.30") { if versions.LessThan(v, "1.30") {
queryRegistry = true queryRegistry = true
} }
adjustForAPIVersion(cliVersion, &service) adjustForAPIVersion(v, &service)
} }
resp, err := sr.backend.UpdateService(vars["id"], version, service, flags, queryRegistry) resp, err := sr.backend.UpdateService(vars["id"], version, service, flags, queryRegistry)