kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity

Merge pull request #19131 from cpuguy83/fix_plugin_error_handling 

Don't error out on plugin err with json
This commit is contained in:
Antonio Murdaca 2016-01-08 12:22:45 +01:00
parent 9e9d7dc884 279dd092b6
commit f4f848b7a5
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/plugins/client.go
View File

@ -134,11 +134,10 @@ func (c *Client) callWithRetry(serviceMethod string, data io.Reader, retry bool)
Err string Err string
} }
remoteErr := responseErr{} remoteErr := responseErr{}
if err := json.Unmarshal(b, &remoteErr); err != nil { if err := json.Unmarshal(b, &remoteErr); err == nil {
return nil, fmt.Errorf("%s: %s", serviceMethod, err) if remoteErr.Err != "" {
} return nil, fmt.Errorf("%s: %s", serviceMethod, remoteErr.Err)
if remoteErr.Err != "" { }
return nil, fmt.Errorf("%s: %s", serviceMethod, remoteErr.Err)
} }
// old way... // old way...
return nil, fmt.Errorf("%s: %s", serviceMethod, string(b)) return nil, fmt.Errorf("%s: %s", serviceMethod, string(b))