diff --git a/daemon/daemon_unix.go b/daemon/daemon_unix.go index 71e167361c..974420a9c3 100644 --- a/daemon/daemon_unix.go +++ b/daemon/daemon_unix.go @@ -839,25 +839,14 @@ func overlaySupportsSelinux() (bool, error) { } defer f.Close() - var symAddr, symType, symName, text string - s := bufio.NewScanner(f) for s.Scan() { - if err := s.Err(); err != nil { - return false, err - } - - text = s.Text() - if _, err := fmt.Sscanf(text, "%s %s %s", &symAddr, &symType, &symName); err != nil { - return false, fmt.Errorf("Scanning '%s' failed: %s", text, err) - } - - // Check for presence of symbol security_inode_copy_up. - if symName == "security_inode_copy_up" { + if strings.HasSuffix(s.Text(), " security_inode_copy_up") { return true, nil } } - return false, nil + + return false, s.Err() } // configureKernelSecuritySupport configures and validates security support for the kernel diff --git a/pkg/idtools/idtools.go b/pkg/idtools/idtools.go index b3af7a4226..db1fd1a9d1 100644 --- a/pkg/idtools/idtools.go +++ b/pkg/idtools/idtools.go @@ -236,10 +236,6 @@ func parseSubidFile(path, username string) (ranges, error) { s := bufio.NewScanner(subidFile) for s.Scan() { - if err := s.Err(); err != nil { - return rangeList, err - } - text := strings.TrimSpace(s.Text()) if text == "" || strings.HasPrefix(text, "#") { continue @@ -260,5 +256,6 @@ func parseSubidFile(path, username string) (ranges, error) { rangeList = append(rangeList, subIDRange{startid, length}) } } - return rangeList, nil + + return rangeList, s.Err() }