kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

Merge pull request #731 from dotcloud/change_containersPs_containersJson_api-feature

Browse source 
* API: rename containers/ps to containers/json
This commit is contained in:
Guillaume J. Charmes 2013-05-28 15:44:20 -07:00
commit f65327555e
4 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
api.go
View file

@ -206,7 +206,7 @@ func getContainersChanges(srv *Server, version float64, w http.ResponseWriter, r
return nil return nil
} }
func getContainersPs(srv *Server, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error { func getContainersJson(srv *Server, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
if err := parseForm(r); err != nil { if err := parseForm(r); err != nil {
return err return err
} }
@ -631,7 +631,8 @@ func ListenAndServe(addr string, srv *Server, logging bool) error {
"/images/search": getImagesSearch, "/images/search": getImagesSearch,
"/images/{name:.*}/history": getImagesHistory, "/images/{name:.*}/history": getImagesHistory,
"/images/{name:.*}/json": getImagesByName, "/images/{name:.*}/json": getImagesByName,
"/containers/ps": getContainersPs, "/containers/ps": getContainersJson,
"/containers/json": getContainersJson,
"/containers/{name:.*}/export": getContainersExport, "/containers/{name:.*}/export": getContainersExport,
"/containers/{name:.*}/changes": getContainersChanges, "/containers/{name:.*}/changes": getContainersChanges,
"/containers/{name:.*}/json": getContainersByName, "/containers/{name:.*}/json": getContainersByName,

6
api_test.go
View file

@ -318,7 +318,7 @@ func TestGetImagesByName(t *testing.T) {
} }
} }
func TestGetContainersPs(t *testing.T) { func TestGetContainersJson(t *testing.T) {
runtime, err := newTestRuntime() runtime, err := newTestRuntime()
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
@ -336,13 +336,13 @@ func TestGetContainersPs(t *testing.T) {
} }
defer runtime.Destroy(container) defer runtime.Destroy(container)
req, err := http.NewRequest("GET", "/containers?quiet=1&all=1", nil) req, err := http.NewRequest("GET", "/containers/json?all=1", nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
r := httptest.NewRecorder() r := httptest.NewRecorder()
if err := getContainersPs(srv, API_VERSION, r, req, nil); err != nil { if err := getContainersJson(srv, API_VERSION, r, req, nil); err != nil {
t.Fatal(err) t.Fatal(err)
} }
containers := []ApiContainers{} containers := []ApiContainers{}

2
commands.go
View file

@ -788,7 +788,7 @@ func (cli *DockerCli) CmdPs(args ...string) error {
v.Set("before", *before) v.Set("before", *before)
} }
body, _, err := cli.call("GET", "/containers/ps?"+v.Encode(), nil) body, _, err := cli.call("GET", "/containers/json?"+v.Encode(), nil)
if err != nil { if err != nil {
return err return err
} }

4
docs/sources/api/docker_remote_api.rst
View file

@ -24,7 +24,7 @@ Docker Remote API
List containers List containers
*************** ***************
.. http:get:: /containers/ps .. http:get:: /containers/json
List containers List containers
@ -32,7 +32,7 @@ List containers
.. sourcecode:: http .. sourcecode:: http
GET /containers/ps?all=1&before=8dfafdbc3a40 HTTP/1.1 GET /containers/json?all=1&before=8dfafdbc3a40 HTTP/1.1
**Example response**: **Example response**: