kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity

Typos and FIXMEs

This commit is contained in:
Solomon Hykes 2013-10-09 19:45:45 -07:00 committed by Victor Vieux
parent 4576d0f802
commit f7a2f0b937
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gograph/gograph.go
View File

@ -104,9 +104,11 @@ func (db *Database) Set(fullPath, id string) (*Entity, error) {
return nil, err return nil, err
} }
defer conn.Close() defer conn.Close()
// FIXME: is rollback implicit when closing the connection?
rollback := func() { rollback := func() {
conn.Exec("ROLLBACK") conn.Exec("ROLLBACK")
} }
// FIXME: use exclusive transactions to avoid race conditions
if _, err := conn.Exec("BEGIN"); err != nil { if _, err := conn.Exec("BEGIN"); err != nil {
return nil, err return nil, err
} }

2
gograph/gograph_test.go
View File

@ -22,7 +22,7 @@ func destroyTestDb(db *Database) {
func TestNewDatabase(t *testing.T) { func TestNewDatabase(t *testing.T) {
db := newTestDb(t) db := newTestDb(t)
if db == nil { if db == nil {
t.Fatal("Datbase should not be nil") t.Fatal("Database should not be nil")
} }
defer destroyTestDb(db) defer destroyTestDb(db)
} }