From fc11efa2dbf72bb493a24650860220a2d4b07c5e Mon Sep 17 00:00:00 2001 From: yupeng Date: Tue, 22 Nov 2016 14:53:11 +0800 Subject: [PATCH] error strings should not be capitalized or end with punctuation Signed-off-by: yupeng --- pkg/system/meminfo_solaris.go | 2 +- pkg/term/windows/ansi_reader.go | 2 +- runconfig/opts/parse.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/system/meminfo_solaris.go b/pkg/system/meminfo_solaris.go index 313c601b12..7f4f84f73a 100644 --- a/pkg/system/meminfo_solaris.go +++ b/pkg/system/meminfo_solaris.go @@ -89,7 +89,7 @@ func ReadMemInfo() (*MemInfo, error) { if ppKernel < 0 || MemTotal < 0 || MemFree < 0 || SwapTotal < 0 || SwapFree < 0 { - return nil, fmt.Errorf("Error getting system memory info %v\n", err) + return nil, fmt.Errorf("error getting system memory info %v\n", err) } meminfo := &MemInfo{} diff --git a/pkg/term/windows/ansi_reader.go b/pkg/term/windows/ansi_reader.go index 58452ad786..0bccf878f9 100644 --- a/pkg/term/windows/ansi_reader.go +++ b/pkg/term/windows/ansi_reader.go @@ -97,7 +97,7 @@ func (ar *ansiReader) Read(p []byte) (int, error) { copiedLength := copy(p, keyBytes) if copiedLength != len(keyBytes) { - return 0, errors.New("Unexpected copy length encountered.") + return 0, errors.New("unexpected copy length encountered") } logger.Debugf("Read p[%d]: % x", copiedLength, p) diff --git a/runconfig/opts/parse.go b/runconfig/opts/parse.go index 9dd716f635..b9631f1a3e 100644 --- a/runconfig/opts/parse.go +++ b/runconfig/opts/parse.go @@ -753,7 +753,7 @@ func parseStorageOpts(storageOpts []string) (map[string]string, error) { opt := strings.SplitN(option, "=", 2) m[opt[0]] = opt[1] } else { - return nil, fmt.Errorf("Invalid storage option.") + return nil, fmt.Errorf("invalid storage option") } } return m, nil