From 2816ec7b001c3ec93c87201bdcafc9097bc23507 Mon Sep 17 00:00:00 2001 From: Derek McGowan Date: Wed, 4 Sep 2019 13:47:16 -0700 Subject: [PATCH] Remove unused router swapper The router swapper was previously used to toggle a debug mode, that code has since been removed. Now this router is unnecessary. Signed-off-by: Derek McGowan --- api/server/router_swapper.go | 30 ------------------------------ api/server/server.go | 16 +++++----------- 2 files changed, 5 insertions(+), 41 deletions(-) delete mode 100644 api/server/router_swapper.go diff --git a/api/server/router_swapper.go b/api/server/router_swapper.go deleted file mode 100644 index e8087492c4..0000000000 --- a/api/server/router_swapper.go +++ /dev/null @@ -1,30 +0,0 @@ -package server // import "github.com/docker/docker/api/server" - -import ( - "net/http" - "sync" - - "github.com/gorilla/mux" -) - -// routerSwapper is an http.Handler that allows you to swap -// mux routers. -type routerSwapper struct { - mu sync.Mutex - router *mux.Router -} - -// Swap changes the old router with the new one. -func (rs *routerSwapper) Swap(newRouter *mux.Router) { - rs.mu.Lock() - rs.router = newRouter - rs.mu.Unlock() -} - -// ServeHTTP makes the routerSwapper to implement the http.Handler interface. -func (rs *routerSwapper) ServeHTTP(w http.ResponseWriter, r *http.Request) { - rs.mu.Lock() - router := rs.router - rs.mu.Unlock() - router.ServeHTTP(w, r) -} diff --git a/api/server/server.go b/api/server/server.go index def0f9f0f0..a8ce5cb163 100644 --- a/api/server/server.go +++ b/api/server/server.go @@ -32,11 +32,10 @@ type Config struct { // Server contains instance details for the server type Server struct { - cfg *Config - servers []*HTTPServer - routers []router.Router - routerSwapper *routerSwapper - middlewares []middleware.Middleware + cfg *Config + servers []*HTTPServer + routers []router.Router + middlewares []middleware.Middleware } // New returns a new instance of the server based on the specified configuration. @@ -80,7 +79,7 @@ func (s *Server) Close() { func (s *Server) serveAPI() error { var chErrors = make(chan error, len(s.servers)) for _, srv := range s.servers { - srv.srv.Handler = s.routerSwapper + srv.srv.Handler = s.createMux() go func(srv *HTTPServer) { var err error logrus.Infof("API listen on %s", srv.l.Addr()) @@ -153,11 +152,6 @@ func (s *Server) makeHTTPHandler(handler httputils.APIFunc) http.HandlerFunc { // This method also enables the Go profiler. func (s *Server) InitRouter(routers ...router.Router) { s.routers = append(s.routers, routers...) - - m := s.createMux() - s.routerSwapper = &routerSwapper{ - router: m, - } } type pageNotFoundError struct{}