From 04748a77664c89340b789ef0a25d65b78477dce0 Mon Sep 17 00:00:00 2001 From: Jonathan Rudenberg Date: Wed, 15 May 2013 15:51:04 -0400 Subject: [PATCH 1/4] Fix logic flaw in builder.mergeConfig --- builder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder.go b/builder.go index 5c51d62b9e..85447b5131 100644 --- a/builder.go +++ b/builder.go @@ -45,7 +45,7 @@ func (builder *Builder) mergeConfig(userConf, imageConf *Config) { userConf.PortSpecs = imageConf.PortSpecs } if !userConf.Tty { - userConf.Tty = userConf.Tty + userConf.Tty = imageConf.Tty } if !userConf.OpenStdin { userConf.OpenStdin = imageConf.OpenStdin From 52ef89f9c20d02ca341c979e3d4cb8bd13aa0146 Mon Sep 17 00:00:00 2001 From: Jonathan Rudenberg Date: Wed, 15 May 2013 15:52:19 -0400 Subject: [PATCH 2/4] Fix mistaken call to fmt.Println --- api.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api.go b/api.go index 8df3291357..86883cdc7d 100644 --- a/api.go +++ b/api.go @@ -363,7 +363,7 @@ func postBuild(srv *Server, w http.ResponseWriter, r *http.Request, vars map[str defer in.Close() fmt.Fprintf(out, "HTTP/1.1 200 OK\r\nContent-Type: application/vnd.docker.raw-stream\r\n\r\n") if err := srv.ImageCreateFromFile(in, out); err != nil { - fmt.Fprintln(out, "Error: %s\n", err) + fmt.Fprintf(out, "Error: %s\n", err) } return nil } From 3a339b2bb3b06a110ccf93146cf020279705df84 Mon Sep 17 00:00:00 2001 From: Jonathan Rudenberg Date: Wed, 15 May 2013 15:56:53 -0400 Subject: [PATCH 3/4] Update AUTHORS --- .mailmap | 4 +++- AUTHORS | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 83c18fa29c..1f38e55e28 100644 --- a/.mailmap +++ b/.mailmap @@ -2,7 +2,7 @@ -Guillaume J. Charmes creack +Guillaume J. Charmes @@ -16,4 +16,6 @@ Tim Terhorst Andy Smith + +Thatcher Peskens diff --git a/AUTHORS b/AUTHORS index e8979aac6b..e7c6834cf4 100644 --- a/AUTHORS +++ b/AUTHORS @@ -1,24 +1,34 @@ +Al Tobey +Alexey Shamrin Andrea Luzzardi Andy Rothfusz Andy Smith Antony Messerli +Barry Allard +Brandon Liu Brian McCallister +Bruno Bigras Caleb Spare Charles Hooper Daniel Mizyrycki Daniel Robinson +Daniel Von Fange Dominik Honnef Don Spaulding +Dr Nic Williams +Evan Wies ezbercih Flavio Castelli Francisco Souza Frederick F. Kautz IV Guillaume J. Charmes +Harley Laue Hunter Blanks Jeff Lindsay Jeremy Grosser Joffrey F John Costa +Jonas Pfenniger Jonathan Rudenberg Julien Barbier Jérôme Petazzoni @@ -27,8 +37,11 @@ Kevin J. Lynagh Louis Opter Maxim Treskin Mikhail Sobolev +Nate Jones Nelson Chen Niall O'Higgins +odk- +Paul Bowsher Paul Hammond Piotr Bogdan Robert Obryk @@ -38,6 +51,8 @@ Silas Sewell Solomon Hykes Sridhar Ratnakumar Thatcher Peskens +Thomas Bikeev +Tianon Gravi Tim Terhorst Troy Howard unclejack From aa0d40747caa8cd9c5cee56046cac011bc3d1065 Mon Sep 17 00:00:00 2001 From: Jonathan Rudenberg Date: Wed, 15 May 2013 16:02:24 -0400 Subject: [PATCH 4/4] Remove broken, redundant struct tag --- auth/auth.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/auth/auth.go b/auth/auth.go index 5a5987ace8..9836a20978 100644 --- a/auth/auth.go +++ b/auth/auth.go @@ -21,7 +21,7 @@ type AuthConfig struct { Username string `json:"username"` Password string `json:"password"` Email string `json:"email"` - rootPath string `json:-` + rootPath string } func NewAuthConfig(username, password, email, rootPath string) *AuthConfig {