moby--moby

Commit Graph

Author	SHA1	Message	Date
Sebastiaan van Stijn	78eab14d0b	Minor refactor and beter coverage for pkg/stringid This slightly simplifies TruncateID() by only trimming the string if needed. Also improved unit-tests for this package; - Add a test for GenerateNonCryptoID() - Add a test for shortening a sha-256 ID - Make TestShortenId() more "unit", by using a fixed string, instead of calling GenerateRandomID() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2016-07-20 00:23:06 +02:00
Richard Burnison	8d1a500303	Only use fallback to short IDs when obvious. As reported in #11294, the Docker daemon will execute contains it shouldn't run in the event that a requested tag is present in an image's ID. This leads to the wrong image being started up silently. This change reduces the risk of such a collision by using the short ID iff the actual revOrTag looks like a short ID (not that it necessarily is). Signed-off-by: Richard Burnison <rburnison@ebay.com>	2015-04-10 13:20:44 -04:00
Antonio Murdaca	b80fae7356	Refactor pkg/common, Fixes #11599 Signed-off-by: Antonio Murdaca <me@runcom.ninja>	2015-03-24 18:19:59 +01:00

Author

SHA1

Message

Date

Sebastiaan van Stijn

78eab14d0b

Minor refactor and beter coverage for pkg/stringid

This slightly simplifies TruncateID() by only
trimming the string if needed.

Also improved unit-tests for this package;

- Add a test for GenerateNonCryptoID()
- Add a test for shortening a sha-256 ID
- Make TestShortenId() more "unit", by using a fixed string, instead of calling GenerateRandomID()

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2016-07-20 00:23:06 +02:00

Richard Burnison

8d1a500303

Only use fallback to short IDs when obvious.

As reported in #11294, the Docker daemon will execute contains it
shouldn't run in the event that a requested tag is present in an image's
ID. This leads to the wrong image being started up silently.

This change reduces the risk of such a collision by using the short ID
iff the actual revOrTag looks like a short ID (not that it necessarily
is).

Signed-off-by: Richard Burnison <rburnison@ebay.com>

2015-04-10 13:20:44 -04:00

Antonio Murdaca

b80fae7356

Refactor pkg/common, Fixes #11599

Signed-off-by: Antonio Murdaca <me@runcom.ninja>

2015-03-24 18:19:59 +01:00

3 Commits