mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
4bafaa00aa
The containerd client is very chatty at the best of times. Because the libcontained API is stateless and references containers and processes by string ID for every method call, the implementation is essentially forced to use the containerd client in a way which amplifies the number of redundant RPCs invoked to perform any operation. The libcontainerd remote implementation has to reload the containerd container, task and/or process metadata for nearly every operation. This in turn amplifies the number of context switches between dockerd and containerd to perform any container operation or handle a containerd event, increasing the load on the system which could otherwise be allocated to workloads. Overhaul the libcontainerd interface to reduce the impedance mismatch with the containerd client so that the containerd client can be used more efficiently. Split the API out into container, task and process interfaces which the consumer is expected to retain so that libcontainerd can retain state---especially the analogous containerd client objects---without having to manage any state-store inside the libcontainerd client. Signed-off-by: Cory Snider <csnider@mirantis.com>
94 lines
2.8 KiB
Go
94 lines
2.8 KiB
Go
package daemon // import "github.com/docker/docker/daemon"
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
containertypes "github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/container"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func newDaemonWithTmpRoot(t *testing.T) (*Daemon, func()) {
|
|
tmp, err := os.MkdirTemp("", "docker-daemon-unix-test-")
|
|
assert.NilError(t, err)
|
|
d := &Daemon{
|
|
repository: tmp,
|
|
root: tmp,
|
|
}
|
|
d.containers = container.NewMemoryStore()
|
|
return d, func() { os.RemoveAll(tmp) }
|
|
}
|
|
|
|
func newContainerWithState(state *container.State) *container.Container {
|
|
return &container.Container{
|
|
ID: "test",
|
|
State: state,
|
|
Config: &containertypes.Config{},
|
|
}
|
|
}
|
|
|
|
// TestContainerDelete tests that a useful error message and instructions is
|
|
// given when attempting to remove a container (#30842)
|
|
func TestContainerDelete(t *testing.T) {
|
|
tt := []struct {
|
|
errMsg string
|
|
fixMsg string
|
|
initContainer func() *container.Container
|
|
}{
|
|
// a paused container
|
|
{
|
|
errMsg: "cannot remove a paused container",
|
|
fixMsg: "Unpause and then stop the container before attempting removal or force remove",
|
|
initContainer: func() *container.Container {
|
|
return newContainerWithState(&container.State{Paused: true, Running: true})
|
|
}},
|
|
// a restarting container
|
|
{
|
|
errMsg: "cannot remove a restarting container",
|
|
fixMsg: "Stop the container before attempting removal or force remove",
|
|
initContainer: func() *container.Container {
|
|
c := newContainerWithState(container.NewState())
|
|
c.SetRunning(nil, nil, true)
|
|
c.SetRestarting(&container.ExitStatus{})
|
|
return c
|
|
}},
|
|
// a running container
|
|
{
|
|
errMsg: "cannot remove a running container",
|
|
fixMsg: "Stop the container before attempting removal or force remove",
|
|
initContainer: func() *container.Container {
|
|
return newContainerWithState(&container.State{Running: true})
|
|
}},
|
|
}
|
|
|
|
for _, te := range tt {
|
|
c := te.initContainer()
|
|
d, cleanup := newDaemonWithTmpRoot(t)
|
|
defer cleanup()
|
|
d.containers.Add(c.ID, c)
|
|
|
|
err := d.ContainerRm(c.ID, &types.ContainerRmConfig{ForceRemove: false})
|
|
assert.Check(t, is.ErrorContains(err, te.errMsg))
|
|
assert.Check(t, is.ErrorContains(err, te.fixMsg))
|
|
}
|
|
}
|
|
|
|
func TestContainerDoubleDelete(t *testing.T) {
|
|
c := newContainerWithState(container.NewState())
|
|
|
|
// Mark the container as having a delete in progress
|
|
c.SetRemovalInProgress()
|
|
|
|
d, cleanup := newDaemonWithTmpRoot(t)
|
|
defer cleanup()
|
|
d.containers.Add(c.ID, c)
|
|
|
|
// Try to remove the container when its state is removalInProgress.
|
|
// It should return an error indicating it is under removal progress.
|
|
err := d.ContainerRm(c.ID, &types.ContainerRmConfig{ForceRemove: true})
|
|
assert.Check(t, is.ErrorContains(err, fmt.Sprintf("removal of container %s is already in progress", c.ID)))
|
|
}
|