1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/libcontainerd
Cory Snider 1bef9e3fbf Fix containerd task deletion after failed start
Deleting a containerd task whose status is Created fails with a
"precondition failed" error. This is because (aside from Windows)
a process is spawned when the task is created, and deleting the task
while the process is running would leak the process if it was allowed.
libcontainerd and the containerd plugin executor mistakenly try to clean
up from a failed start by deleting the created task, which will always
fail with the aforementined error. Change them to pass the
`WithProcessKill` delete option so the cleanup has a chance to succeed.

Signed-off-by: Cory Snider <csnider@mirantis.com>
2022-11-02 13:48:13 -04:00
..
local Refactor libcontainerd to minimize c8d RPCs 2022-08-24 14:59:08 -04:00
queue bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
remote Fix containerd task deletion after failed start 2022-11-02 13:48:13 -04:00
supervisor Lock OS threads when exec'ing with Pdeathsig 2022-10-05 12:18:03 -04:00
types Refactor libcontainerd to minimize c8d RPCs 2022-08-24 14:59:08 -04:00
libcontainerd_linux.go Configure shims from runtime config 2020-07-13 14:18:02 -07:00
libcontainerd_windows.go Remove unused useShimV2() 2020-07-15 14:28:48 +02:00
replace.go Share logic to create-or-replace a container 2022-08-24 14:59:08 -04:00