010adeec55
Before this change, the error returned to the user would include the physical path inside the tmp dir on the daemon host. These paths should be considered an implementation detail, and provide no value to the user. Printing the tmp path can confuse users, and will be even more confusing if the daemon is running remotely (or in a VM, such as on Docker Desktop), in which case the path in the error message does not exist on the local machine; echo -e "FROM busybox\nCOPY /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.57kB Step 1/2 : FROM busybox ---> 1c35c4412082 Step 2/2 : COPY /some/non-existing/file.txt . COPY failed: stat /var/lib/docker/tmp/docker-builder405687992/some/non-existing/file.txt: no such file or directory When copying files from an image or a build stage, using `--from`, the error is similarly confusing: echo -e "FROM busybox\nCOPY --from=busybox /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 4.671kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : COPY --from=busybox /some/non-existing/file.txt . COPY failed: stat /var/lib/docker/overlay2/ef34239c80526c779b7afaeaedbf11c1b201d7f7681d45613102c4541da0e156/merged/some/non-existing/file.txt: no such file or directory This patch updates the error messages to be more user-friendly. Changes are slightly different, depending on if the source was a local path, or an image (or build-stage), using `--from`. If `--from` is used, only the path is updated, and we print the relative path instead of the full path; echo -e "FROM busybox\nCOPY --from=busybox /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.583kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : COPY --from=busybox /some/non-existing/file.txt . COPY failed: stat some/non-existing/file.txt: file does not exist In other cases, additional information is added to mention "build context" and ".dockerignore", which could provide the user some hints to find the problem: echo -e "FROM busybox\nCOPY /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.583kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : COPY /some/non-existing/file.txt . COPY failed: file not found in build context or excluded by .dockerignore: stat some/non-existing/file.txt: file does not exist echo -e "FROM busybox\nADD /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.583kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : ADD /some/non-existing/file.txt . ADD failed: file not found in build context or excluded by .dockerignore: stat some/non-existing/file.txt: file does not exist This patch only improves the error for the classic builder. Similar changes could be made for BuildKit, which produces equally, or even more confusing errors; echo -e "FROM busybox\nCOPY /some/non-existing/file.txt ." | DOCKER_BUILDKIT=1 docker build -f- . [+] Building 1.2s (6/6) FINISHED => [internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 85B 0.0s => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [internal] load metadata for docker.io/library/busybox:latest 1.2s => [internal] load build context 0.0s => => transferring context: 2B 0.0s => CACHED [1/2] FROM docker.io/library/busybox@sha256:4f47c01... 0.0s => ERROR [2/2] COPY /some/non-existing/file.txt . 0.0s ------ > [2/2] COPY /some/non-existing/file.txt .: ------ failed to compute cache key: failed to walk /var/lib/docker/tmp/buildkit-mount181923793/some/non-existing: lstat /var/lib/docker/tmp/buildkit-mount181923793/some/non-existing: no such file or directory echo -e "FROM busybox\nCOPY --from=busybox /some/non-existing/file.txt ." | DOCKER_BUILDKIT=1 docker build -f- . [+] Building 2.5s (6/6) FINISHED => [internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 100B 0.0s => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [internal] load metadata for docker.io/library/busybox:latest 1.2s => FROM docker.io/library/busybox:latest 1.2s => => resolve docker.io/library/busybox:latest 1.2s => CACHED [stage-0 1/2] FROM docker.io/library/busybox@sha256:4f47c01... 0.0s => ERROR [stage-0 2/2] COPY --from=busybox /some/non-existing/file.txt . 0.0s ------ > [stage-0 2/2] COPY --from=busybox /some/non-existing/file.txt .: ------ failed to compute cache key: failed to walk /var/lib/docker/overlay2/2a796d91e46fc038648c6010f062bdfd612ee62b0e8fe77bc632688e3fba32d9/merged/some/non-existing: lstat /var/lib/docker/overlay2/2a796d91e46fc038648c6010f062bdfd612ee62b0e8fe77bc632688e3fba32d9/merged/some/non-existing: no such file or directory Signed-off-by: Sebastiaan van Stijn <github@gone.nl> |
||
---|---|---|
.github | ||
api | ||
builder | ||
cli | ||
client | ||
cmd/dockerd | ||
container | ||
contrib | ||
daemon | ||
distribution | ||
dockerversion | ||
docs | ||
errdefs | ||
hack | ||
image | ||
integration | ||
integration-cli | ||
internal/test/suite | ||
layer | ||
libcontainerd | ||
oci | ||
opts | ||
patches | ||
pkg | ||
plugin | ||
profiles | ||
project | ||
reference | ||
registry | ||
reports | ||
restartmanager | ||
rootless | ||
runconfig | ||
testutil | ||
vendor | ||
volume | ||
.DEREK.yml | ||
.dockerignore | ||
.gitignore | ||
.mailmap | ||
AUTHORS | ||
CHANGELOG.md | ||
CONTRIBUTING.md | ||
Dockerfile | ||
Dockerfile.buildx | ||
Dockerfile.e2e | ||
Dockerfile.simple | ||
Dockerfile.windows | ||
Jenkinsfile | ||
LICENSE | ||
MAINTAINERS | ||
Makefile | ||
NOTICE | ||
README.md | ||
ROADMAP.md | ||
SECURITY.md | ||
TESTING.md | ||
VENDORING.md | ||
codecov.yml | ||
poule.yml | ||
vendor.conf |
README.md
The Moby Project
Moby is an open-source project created by Docker to enable and accelerate software containerization.
It provides a "Lego set" of toolkit components, the framework for assembling them into custom container-based systems, and a place for all container enthusiasts and professionals to experiment and exchange ideas. Components include container build tools, a container registry, orchestration tools, a runtime and more, and these can be used as building blocks in conjunction with other tools and projects.
Principles
Moby is an open project guided by strong principles, aiming to be modular, flexible and without too strong an opinion on user experience. It is open to the community to help set its direction.
- Modular: the project includes lots of components that have well-defined functions and APIs that work together.
- Batteries included but swappable: Moby includes enough components to build fully featured container system, but its modular architecture ensures that most of the components can be swapped by different implementations.
- Usable security: Moby provides secure defaults without compromising usability.
- Developer focused: The APIs are intended to be functional and useful to build powerful tools. They are not necessarily intended as end user tools but as components aimed at developers. Documentation and UX is aimed at developers not end users.
Audience
The Moby Project is intended for engineers, integrators and enthusiasts looking to modify, hack, fix, experiment, invent and build systems based on containers. It is not for people looking for a commercially supported system, but for people who want to work and learn with open source code.
Relationship with Docker
The components and tools in the Moby Project are initially the open source components that Docker and the community have built for the Docker Project. New projects can be added if they fit with the community goals. Docker is committed to using Moby as the upstream for the Docker Product. However, other projects are also encouraged to use Moby as an upstream, and to reuse the components in diverse ways, and all these uses will be treated in the same way. External maintainers and contributors are welcomed.
The Moby project is not intended as a location for support or feature requests for Docker products, but as a place for contributors to work on open source code, fix bugs, and make the code more useful. The releases are supported by the maintainers, community and users, on a best efforts basis only, and are not intended for customers who want enterprise or commercial support; Docker EE is the appropriate product for these use cases.
Legal
Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.
Use and transfer of Moby may be subject to certain restrictions by the United States and other governments.
It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.
For more information, please see https://www.bis.doc.gov
Licensing
Moby is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.