1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/runconfig/opts
Yong Tang 01d3a16f58 Return error if env file contains non-ascii or utf8 bytes (for windows)
This fix tries to address the issue raised in 26179 where an env file
with non-ascii or utf8 bytes will crash on windows platform.

The issue is two-fold:
- Windows will adds a BOM mark at the begining with Notepad as the editor
- Non-utf8 bytes can not be handled by env file parser.

This fix removes utf8 BOM marker if exists so that utf8 encoded env file
could be processed.
This fix also returns an error (instead of a runtime CreateProcess crash)
if env file contains non-utf8 bytes, thus giving users better experiences.

Additional test cases has been added in unit tests.

This fix fixes 26179.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2016-10-25 12:34:25 -07:00
..
fixtures Return error if env file contains non-ascii or utf8 bytes (for windows) 2016-10-25 12:34:25 -07:00
envfile.go Return error if env file contains non-ascii or utf8 bytes (for windows) 2016-10-25 12:34:25 -07:00
envfile_test.go fix typos 2016-06-02 17:17:22 +08:00
opts.go Add init process for zombie fighting 2016-09-19 17:33:50 -07:00
opts_test.go validate build-arg 2016-09-12 18:02:21 +08:00
parse.go Update docker stop and docker restart to allow not specifying timeout and use the one specified at container creation time. 2016-10-17 12:53:35 -07:00
parse_test.go Return error if env file contains non-ascii or utf8 bytes (for windows) 2016-10-25 12:34:25 -07:00
runtime.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00
throttledevice.go all: replace loop with single append 2016-10-13 13:31:52 -07:00
ulimit.go Convert 'docker run' to a cobra command and to use pflags 2016-06-04 13:55:35 +02:00
ulimit_test.go Move ulimit options to runconfig opts 2015-12-23 13:27:58 -05:00
weightdevice.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00