mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
fcb083c6ac
Removed images were not cleaned up from the digest-set that is used for the search index. Fixes #18437 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
244 lines
5.8 KiB
Go
244 lines
5.8 KiB
Go
package image
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/docker/distribution/digest"
|
|
"github.com/docker/docker/layer"
|
|
)
|
|
|
|
func TestRestore(t *testing.T) {
|
|
tmpdir, err := ioutil.TempDir("", "images-fs-store")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(tmpdir)
|
|
fs, err := NewFSStoreBackend(tmpdir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
id1, err := fs.Set([]byte(`{"comment": "abc", "rootfs": {"type": "layers"}}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
_, err = fs.Set([]byte(`invalid`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
id2, err := fs.Set([]byte(`{"comment": "def", "rootfs": {"type": "layers", "diff_ids": ["2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae"]}}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = fs.SetMetadata(id2, "parent", []byte(id1))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
is, err := NewImageStore(fs, &mockLayerGetReleaser{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
imgs := is.Map()
|
|
if actual, expected := len(imgs), 2; actual != expected {
|
|
t.Fatalf("invalid images length, expected 2, got %q", len(imgs))
|
|
}
|
|
|
|
img1, err := is.Get(ID(id1))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if actual, expected := img1.computedID, ID(id1); actual != expected {
|
|
t.Fatalf("invalid image ID: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
if actual, expected := img1.computedID.String(), string(id1); actual != expected {
|
|
t.Fatalf("invalid image ID string: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
img2, err := is.Get(ID(id2))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if actual, expected := img1.Comment, "abc"; actual != expected {
|
|
t.Fatalf("invalid comment for image1: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
if actual, expected := img2.Comment, "def"; actual != expected {
|
|
t.Fatalf("invalid comment for image2: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
p, err := is.GetParent(ID(id1))
|
|
if err == nil {
|
|
t.Fatal("expected error for getting parent")
|
|
}
|
|
|
|
p, err = is.GetParent(ID(id2))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if actual, expected := p, ID(id1); actual != expected {
|
|
t.Fatalf("invalid parent: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
children := is.Children(ID(id1))
|
|
if len(children) != 1 {
|
|
t.Fatalf("invalid children length: %q", len(children))
|
|
}
|
|
if actual, expected := children[0], ID(id2); actual != expected {
|
|
t.Fatalf("invalid child for id1: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
heads := is.Heads()
|
|
if actual, expected := len(heads), 1; actual != expected {
|
|
t.Fatalf("invalid images length: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
sid1, err := is.Search(string(id1)[:10])
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if actual, expected := sid1, ID(id1); actual != expected {
|
|
t.Fatalf("searched ID mismatch: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
sid1, err = is.Search(digest.Digest(id1).Hex()[:6])
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if actual, expected := sid1, ID(id1); actual != expected {
|
|
t.Fatalf("searched ID mismatch: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
invalidPattern := digest.Digest(id1).Hex()[1:6]
|
|
_, err = is.Search(invalidPattern)
|
|
if err == nil {
|
|
t.Fatalf("expected search for %q to fail", invalidPattern)
|
|
}
|
|
|
|
}
|
|
|
|
func TestAddDelete(t *testing.T) {
|
|
tmpdir, err := ioutil.TempDir("", "images-fs-store")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(tmpdir)
|
|
fs, err := NewFSStoreBackend(tmpdir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
is, err := NewImageStore(fs, &mockLayerGetReleaser{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
id1, err := is.Create([]byte(`{"comment": "abc", "rootfs": {"type": "layers", "diff_ids": ["2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae"]}}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if actual, expected := id1, ID("sha256:8d25a9c45df515f9d0fe8e4a6b1c64dd3b965a84790ddbcc7954bb9bc89eb993"); actual != expected {
|
|
t.Fatalf("create ID mismatch: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
img, err := is.Get(id1)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if actual, expected := img.Comment, "abc"; actual != expected {
|
|
t.Fatalf("invalid comment in image: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
id2, err := is.Create([]byte(`{"comment": "def", "rootfs": {"type": "layers", "diff_ids": ["2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae"]}}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = is.SetParent(id2, id1)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
pid1, err := is.GetParent(id2)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if actual, expected := pid1, id1; actual != expected {
|
|
t.Fatalf("invalid parent for image: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
_, err = is.Delete(id1)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
_, err = is.Get(id1)
|
|
if err == nil {
|
|
t.Fatalf("expected get for deleted image %q to fail", id1)
|
|
}
|
|
_, err = is.Get(id2)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
pid1, err = is.GetParent(id2)
|
|
if err == nil {
|
|
t.Fatalf("expected parent check for image %q to fail, got %q", id2, pid1)
|
|
}
|
|
|
|
}
|
|
|
|
func TestSearchAfterDelete(t *testing.T) {
|
|
tmpdir, err := ioutil.TempDir("", "images-fs-store")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(tmpdir)
|
|
fs, err := NewFSStoreBackend(tmpdir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
is, err := NewImageStore(fs, &mockLayerGetReleaser{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
id, err := is.Create([]byte(`{"comment": "abc", "rootfs": {"type": "layers"}}`))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
id1, err := is.Search(string(id)[:15])
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if actual, expected := id1, id; expected != actual {
|
|
t.Fatalf("wrong id returned from search: expected %q, got %q", expected, actual)
|
|
}
|
|
|
|
if _, err := is.Delete(id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := is.Search(string(id)[:15]); err == nil {
|
|
t.Fatal("expected search after deletion to fail")
|
|
}
|
|
}
|
|
|
|
type mockLayerGetReleaser struct{}
|
|
|
|
func (ls *mockLayerGetReleaser) Get(layer.ChainID) (layer.Layer, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (ls *mockLayerGetReleaser) Release(layer.Layer) ([]layer.Metadata, error) {
|
|
return nil, nil
|
|
}
|