mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
053c3557b3
Two problems how they are today: In the current systemd unit files it is impossible to have the docker.service started at system boot. Instead enableing docker.service will actually enable docker.socket. This is a problem, as that means any container with --restart=always will not launch on reboot. And of course as soon as you log in and type docker ps, docker.service will be launched and now your images are running. Talk about a PITA to debug! The fix is to just install docker.service when people ask docker.service to be enabled. If an admin wants to enable docker.socket instead, that is fine and will work just as it does today. The second problem is a common docker devel workflow, although not something normal admins would hit. In this case consider a dev doing the following: systemctl stop docker.service docker -d [run commands] [^C] systemctl start docker.service Running docker -d (without -F fd://) will clean up the /var/run/docker.sock when it exits. Remember, you just ran the docker daemon not telling it about socket actviation, so cleaning up its socket makes sense! The new docker, started by systemd will expect socket activation, but the last one cleaned up the docker.sock. So things are just broken. You can, today, work around this by restarting docker.socket. This fixes it by telling docker.socket that it is PartOf=docker.service. So when docker.service is started/stopped/restarted docker.socket will also be started/stopped/restarted. So the above semi-common devel workflow will be fine. When docker.service is stopped, so is docker.socket, docker -d (without -F fd://) will create and delete /var/run/docker.sock. Starting docker.service again will restart docker.socket, which will create the file an all is happy in the word. Signed-off-by: Eric Paris <eparis@redhat.com> |
||
|---|---|---|
| .. | ||
| completion | ||
| desktop-integration | ||
| docker-device-tool | ||
| host-integration | ||
| init | ||
| mkimage | ||
| syntax | ||
| udev | ||
| vagrant-docker | ||
| check-config.sh | ||
| MAINTAINERS | ||
| mkimage-alpine.sh | ||
| mkimage-arch-pacman.conf | ||
| mkimage-arch.sh | ||
| mkimage-busybox.sh | ||
| mkimage-crux.sh | ||
| mkimage-debootstrap.sh | ||
| mkimage-rinse.sh | ||
| mkimage-unittest.sh | ||
| mkimage-yum.sh | ||
| mkimage.sh | ||
| mkseccomp.pl | ||
| mkseccomp.sample | ||
| nuke-graph-directory.sh | ||
| README | ||
The `contrib` directory contains scripts, images, and other helpful things which are not part of the core docker distribution. Please note that they could be out of date, since they do not receive the same attention as the rest of the repository.