mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
608702b980
We now have one place that keeps track of (most) devices that are allowed and created within the container. That place is pkg/libcontainer/devices/devices.go This fixes several inconsistencies between which devices were created in the lxc backend and the native backend. It also fixes inconsistencies between wich devices were created and which were allowed. For example, /dev/full was being created but it was not allowed within the cgroup. It also declares the file modes and permissions of the default devices, rather than copying them from the host. This is in line with docker's philosphy of not being host dependent. Docker-DCO-1.1-Signed-off-by: Timothy Hobbs <timothyhobbs@seznam.cz> (github: https://github.com/timthelion)
138 lines
2.9 KiB
Go
138 lines
2.9 KiB
Go
package lxc
|
|
|
|
import (
|
|
"bufio"
|
|
"fmt"
|
|
"github.com/dotcloud/docker/daemon/execdriver"
|
|
"io/ioutil"
|
|
"math/rand"
|
|
"os"
|
|
"path"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/dotcloud/docker/pkg/libcontainer/devices"
|
|
)
|
|
|
|
func TestLXCConfig(t *testing.T) {
|
|
root, err := ioutil.TempDir("", "TestLXCConfig")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(root)
|
|
|
|
os.MkdirAll(path.Join(root, "containers", "1"), 0777)
|
|
|
|
// Memory is allocated randomly for testing
|
|
rand.Seed(time.Now().UTC().UnixNano())
|
|
var (
|
|
memMin = 33554432
|
|
memMax = 536870912
|
|
mem = memMin + rand.Intn(memMax-memMin)
|
|
cpuMin = 100
|
|
cpuMax = 10000
|
|
cpu = cpuMin + rand.Intn(cpuMax-cpuMin)
|
|
)
|
|
|
|
driver, err := NewDriver(root, false)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
command := &execdriver.Command{
|
|
ID: "1",
|
|
Resources: &execdriver.Resources{
|
|
Memory: int64(mem),
|
|
CpuShares: int64(cpu),
|
|
},
|
|
Network: &execdriver.Network{
|
|
Mtu: 1500,
|
|
Interface: nil,
|
|
},
|
|
AllowedDevices: make([]devices.Device, 0),
|
|
}
|
|
p, err := driver.generateLXCConfig(command)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
grepFile(t, p,
|
|
fmt.Sprintf("lxc.cgroup.memory.limit_in_bytes = %d", mem))
|
|
|
|
grepFile(t, p,
|
|
fmt.Sprintf("lxc.cgroup.memory.memsw.limit_in_bytes = %d", mem*2))
|
|
}
|
|
|
|
func TestCustomLxcConfig(t *testing.T) {
|
|
root, err := ioutil.TempDir("", "TestCustomLxcConfig")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(root)
|
|
|
|
os.MkdirAll(path.Join(root, "containers", "1"), 0777)
|
|
|
|
driver, err := NewDriver(root, false)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
command := &execdriver.Command{
|
|
ID: "1",
|
|
Privileged: false,
|
|
Config: map[string][]string{
|
|
"lxc": {
|
|
"lxc.utsname = docker",
|
|
"lxc.cgroup.cpuset.cpus = 0,1",
|
|
},
|
|
},
|
|
Network: &execdriver.Network{
|
|
Mtu: 1500,
|
|
Interface: nil,
|
|
},
|
|
}
|
|
|
|
p, err := driver.generateLXCConfig(command)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
grepFile(t, p, "lxc.utsname = docker")
|
|
grepFile(t, p, "lxc.cgroup.cpuset.cpus = 0,1")
|
|
}
|
|
|
|
func grepFile(t *testing.T, path string, pattern string) {
|
|
f, err := os.Open(path)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
r := bufio.NewReader(f)
|
|
var (
|
|
line string
|
|
)
|
|
err = nil
|
|
for err == nil {
|
|
line, err = r.ReadString('\n')
|
|
if strings.Contains(line, pattern) == true {
|
|
return
|
|
}
|
|
}
|
|
t.Fatalf("grepFile: pattern \"%s\" not found in \"%s\"", pattern, path)
|
|
}
|
|
|
|
func TestEscapeFstabSpaces(t *testing.T) {
|
|
var testInputs = map[string]string{
|
|
" ": "\\040",
|
|
"": "",
|
|
"/double space": "/double\\040\\040space",
|
|
"/some long test string": "/some\\040long\\040test\\040string",
|
|
"/var/lib/docker": "/var/lib/docker",
|
|
" leading": "\\040leading",
|
|
"trailing ": "trailing\\040",
|
|
}
|
|
for in, exp := range testInputs {
|
|
if out := escapeFstabSpaces(in); exp != out {
|
|
t.Logf("Expected %s got %s", exp, out)
|
|
t.Fail()
|
|
}
|
|
}
|
|
}
|